You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Packaging failed because emit-native-index loaded the project file, which needs the game DOL the payload doesn't have. The aurora fingerprint also hashed the submodule's .git file on users' machines (zip extraction drops the hidden attribute), so the prebuilt package was always rejected and aurora plus the runtime were compiled from source.
Summary by CodeRabbit
Build & Packaging
Installers now generate native indexes from the bundled runtime’s source files rather than project configuration.
Native-index generation no longer receives the project’s game-input validation path.
Build Reliability
Source fingerprinting now consistently handles dot-prefixed paths across third-party and Aurora sources. Aurora fingerprinting continues to exclude extern and build paths.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: d42e3218-a057-4cc5-9b23-425424675e52
📥 Commits
Reviewing files that changed from the base of the PR and between efedf42 and 3186e5f.
📒 Files selected for processing: 4
Launcher/Build-Installer.ps1
Launcher/NativeBuildFlags.ps1
Launcher/build-appimage.sh
Launcher/macos/build-setup-pkg.command
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
📝 Walkthrough
Launcher build commands now provide runtime source directories to native-index generation. Source fingerprint functions now filter dot-prefixed path components.
The fingerprint functions enumerate hidden files and exclude paths with dot-prefixed components. The Aurora fingerprint retains its extern and build exclusions.
Packaging now generates native indexes from staged runtime sources, avoiding reliance on game-project inputs. The inspected changes reveal no concrete packaging mismatch, so no material merge risk is established.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main changes: fixing prebuilt package native-index generation and Aurora fingerprint handling.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packaging failed because emit-native-index loaded the project file, which needs the game DOL the payload doesn't have. The aurora fingerprint also hashed the submodule's .git file on users' machines (zip extraction drops the hidden attribute), so the prebuilt package was always rejected and aurora plus the runtime were compiled from source.
Summary by CodeRabbit
externandbuildpaths.