Skip to content

Fix prebuilt packaging - #311

Merged
patchzyy merged 1 commit into
mainfrom
fix-prebuilt-packaging
Oct 18, 2026
Merged

patchzyy merged 1 commit into
mainfrom
fix-prebuilt-packaging

Conversation

@patchzyy

@patchzyy patchzyy commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Packaging failed because emit-native-index loaded the project file, which needs the game DOL the payload doesn't have. The aurora fingerprint also hashed the submodule's .git file on users' machines (zip extraction drops the hidden attribute), so the prebuilt package was always rejected and aurora plus the runtime were compiled from source.

Summary by CodeRabbit

  • Build & Packaging
    • Installers now generate native indexes from the bundled runtime’s source files rather than project configuration.
    • Native-index generation no longer receives the project’s game-input validation path.
  • Build Reliability
    • Source fingerprinting now consistently handles dot-prefixed paths across third-party and Aurora sources. Aurora fingerprinting continues to exclude extern and build paths.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d42e3218-a057-4cc5-9b23-425424675e52
📥 Commits

Reviewing files that changed from the base of the PR and between efedf42 and 3186e5f.

📒 Files selected for processing: 4
  • Launcher/Build-Installer.ps1
  • Launcher/NativeBuildFlags.ps1
  • Launcher/build-appimage.sh
  • Launcher/macos/build-setup-pkg.command

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Launcher build commands now provide runtime source directories to native-index generation. Source fingerprint functions now filter dot-prefixed path components.

Changes: Launcher build behavior

Layer / File(s) Summary
Native-index source directory input
Launcher/Build-Installer.ps1, Launcher/build-appimage.sh, Launcher/macos/build-setup-pkg.command
These commands pass the runtime source directory to native-index generation instead of the project configuration file.
Source fingerprint path filters
Launcher/NativeBuildFlags.ps1
The fingerprint functions enumerate hidden files and exclude paths with dot-prefixed components. The Aurora fingerprint retains its extern and build exclusions.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: theofficialgman

Merge Risk: ⚪ Minimal · up to 3186e

Packaging now generates native indexes from staged runtime sources, avoiding reliance on game-project inputs. The inspected changes reveal no concrete packaging mismatch, so no material merge risk is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main changes: fixing prebuilt package native-index generation and Aurora fingerprint handling.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patchzyy
patchzyy merged commit 16bfe7b into main Oct 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant