Repository navigation
fix: link the code of conduct everywhere and fix the sessions page - #180
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three problems from the production CoC rollout.
No Code of Conduct link. Production has no
SLACK_COC_URL, so the Slack DM, the form, the email and/slackall hid the link. Staging has the setting, so the staging test showed the link.SlackService.code_of_conduct_urlnow falls back to https://patchworklabs.org/conduct.DMs already sent. The new
bin/rails slack:coc:refresh SEND=1 DEADLINE=2026-11-01task rewrites the DMs inusers.slack_coc_messageswith the current text and link (chat.update). It sends no new DM and no email. It is a preview withoutSEND=1.Sessions page 500.
/profile/sessionscalledcurrent_user_session, which was not a helper method. It is now.Copy: the update no longer mentions mentorship.
Tests: RSpec (819), Minitest and RuboCop pass. New specs cover the URL fallback, the DM rewrite, the refresh job and the sessions page.