Repository navigation
feat: check caa records in check_zones - #16
Merged
Merged
Conversation
octoDNS planThis pull request changes no DNS records. Planned against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rule 8 to
tools/check_zones.py. A typo in a CAA record, such asletsencrypt.com, now fails./bin/validate. Without this rule, the typo fails at the next certificate renewal.The rule fails when:
issueorissuewildrecord names a CA that is not inKNOWN_CAS(letsencrypt.org,pki.goog,sectigo.com,ssl.com). To allow a new CA, add it toKNOWN_CASin the same pull request.issue,issuewildoriodef, or the flags are not the number 0 or 128.iodefvalue does not start withmailto:orhttps://.issuerecords and they do not includeletsencrypt.org. Vercel, Traefik on alastor and the thimble VPN get certificates from Let's Encrypt.flowchart TD R[CAA value] --> T{tag} T -->|issue / issuewild| C{"CA (lower case, no params, no trailing dot) in KNOWN_CAS?"} T -->|iodef| I{mailto: or https://?} T -->|other| E1[error] C -->|no| E2[error] I -->|no| E3[error] A["apex issue set"] --> L{"includes letsencrypt.org?"} L -->|no| E4[error]The CA match ignores case, a trailing dot and the parameters after
;. An empty CA (;) is allowed. If the apex has noissuerecord, RFC 8659 lets every CA issue, so the Let's Encrypt rule does not apply.This PR does not depend on #15. The zone file in #15 passes this rule.
Tests
tools/test_check_zones.py. All 66 tool tests pass../bin/validatepasses on this branch.CLAUDE.mdare updated.