Repository navigation
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+279
to
+284
| let mut ids_by_title = HashMap::new(); | ||
| for target in TARGETS.list(&tenant_id).await? { | ||
| ids_by_title | ||
| .entry(target.name) | ||
| .or_insert_with(Vec::new) | ||
| .push(target.id); |
There was a problem hiding this comment.
import_alert adds title matching, ambiguity checks, and tenant-specific lookup without tests for these behaviors. Add handler tests for a successful import, missing and duplicate titles, malformed targets, and a title that exists only in another tenant. These would catch changes that reject valid imports or attach the wrong target.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
POST /api/v1/alerts/importwith target titles intargets.
The PR appears safe to merge; the remaining test coverage gap is non-blocking.Findings
Summary
Adds
POST /api/v1/alerts/importto create alerts using target titles.Reviews (2) · Last reviewed commit: "test: cover alert import api" · Reviewed by Greptile