Skip to content

refactor: Bump @microlink/react-json-view from 1.31.22 to 1.31.40 - #3496

Merged
mtrezza merged 2 commits into
parse-community:alphafrom
mtrezza:refactor/microlink-react-json-view-1.31.40
Oct 17, 2026
Merged

mtrezza merged 2 commits into
parse-community:alphafrom
mtrezza:refactor/microlink-react-json-view-1.31.40

Conversation

@mtrezza

@mtrezza mtrezza commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Pull Request

Issue

Closes #3478

Approach

Bumps @microlink/react-json-view from 1.31.22 to 1.31.40 (pinned exactly). It also adds tests in a separate commit before the upgrade. Until now, no tests covered this dependency. The tests pass with both 1.31.22 and 1.31.40.

Usage in this project: only the Playground (Playground.react.js) imports it. The console output renders logged objects and arrays read-only with collapsed={2}, theme="solarized", name={false}, displayObjectSize={false}, displayDataTypes={false}, enableClipboard={true} and a custom style, without edit, add or delete callbacks. The console overrides of console.error and console.warn skip messages that include react-json-view error (isReactJsonError).

Tests (src/lib/tests/PlaygroundJsonView.test.js) render the component with the props of the Playground console output, using react-dom in jsdom:

  • Rendering: the entries of a logged object, the items of a logged array, and a date value. The Playground logs createdAt and updatedAt of a Parse.Object as Date objects.
  • Props: the root name, data types and object sizes are hidden, two levels are expanded and deeper objects are collapsed, and the solarized theme background and the console style are applied.
  • Console: rendering logs no errors or warnings, which the Playground console would otherwise capture. An invalid src logs the error message that isReactJsonError filters.
  • Clipboard: copying a logged object writes formatted JSON, and copying a number value writes the number.

Peer dependencies: unchanged, react and react-dom >= 15, which accepts React 19.2.7. No release in this range mentions React 19, and apart from the clipboard text the component source is unchanged. The engines (node >=17), the dependencies (react-base16-styling, react-lifecycles-compat, react-textarea-autosize) and the entry points (dist/main.js, index.mjs) are also unchanged.

Lock file changes: only node_modules/@microlink/react-json-view 1.31.22 → 1.31.40.

Changes

Comparing the source of 1.31.22 and 1.31.40, CopyToClipboard.js is the only changed source file. The other differences in the published bundle come from the build changes in 1.31.34 and 1.31.39.

Breaking Changes

None

Code Changes Required

None. The upgrade is a drop-in replacement. The only code change is the new tests.

Tasks

  • Add tests

Summary by CodeRabbit

  • Updates
    • Updated the JSON viewer used in the Playground.
  • Tests
    • Expanded coverage for displaying JSON objects, arrays, and dates, as well as copying JSON and plain-text values.
    • Added checks for viewer presentation and error handling.

@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: bec317b5-d42e-473b-a253-4887a9d9a174
📥 Commits

Reviewing files that changed from the base of the PR and between d1fb925 and 81477e0.

📒 Files selected for processing: 3
  • package-lock.json
  • package.json
  • src/lib/tests/PlaygroundJsonView.test.js

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The @microlink/react-json-view dependency is updated from 1.31.22 to 1.31.40. New tests cover Playground JSON rendering and clipboard behavior.

Changes: JSON viewer dependency update

Layer / File(s) Summary
Update and verify the JSON viewer
package.json, package-lock.json, src/lib/tests/PlaygroundJsonView.test.js
The dependency and lockfile move to version 1.31.40. Tests cover rendering objects, arrays, and dates; display options and expansion; error handling; and clipboard copying.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Merge Risk: ⚪ Minimal · up to 81477

The dependency update and Playground tests are ready for normal checks; no merge-blocking issue was identified.

Pre-merge checks: Passed 6 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 6 passed
Check name Status Explanation
Title check Passed The title begins with the allowed prefix "refactor:" and clearly describes the dependency upgrade.
Description check Passed The description includes all required sections, explains the dependency upgrade and tests, links the issue, and marks the applicable task complete.
Linked Issues check Passed Issue [#3478] requires an upgrade from @microlink/react-json-view 1.31.22 to 1.31.40. package.json pins 1.31.40, and package-lock.json updates the direct dependency and resolved package entry to…
Out of Scope Changes check Passed The changes stay within issue [#3478]. The package manifest and lockfile update the requested dependency. PlaygroundJsonView.test.js tests the project's existing use of that dependency in the Playgr…
Security Check Passed No security vulnerability is introduced by the reviewed range. The production change only pins @microlink/react-json-view from 1.31.22 to 1.31.40; the lockfile keeps the same dependencies and uses a n…
Engage In Review Feedback Passed No review feedback comments or actionable findings were supplied. Therefore, there was no feedback requiring engagement, implementation, or reviewer agreement.
Full details: Linked Issues check

Explanation

Issue [#3478] requires an upgrade from @microlink/react-json-view 1.31.22 to 1.31.40. package.json pins 1.31.40, and package-lock.json updates the direct dependency and resolved package entry to 1.31.40. The added PlaygroundJsonView.test.js tests cover the existing Playground usage, including rendering, props, console behavior, and clipboard output. These tests support the dependency upgrade and do not leave a stated coding requirement unmet.

Full details: Out of Scope Changes check

Explanation

The changes stay within issue [#3478]. The package manifest and lockfile update the requested dependency. PlaygroundJsonView.test.js tests the project's existing use of that dependency in the Playground console. No unrelated application behavior or unrelated dependency changes are shown.

Full details: Security Check

Explanation

No security vulnerability is introduced by the reviewed range. The production change only pins @microlink/react-json-view from 1.31.22 to 1.31.40; the lockfile keeps the same dependencies and uses a new integrity hash. The other 174 changed lines are tests with fixed local data. The published bundle uses text rendering and clipboard APIs, with no innerHTML, dynamic code execution, network requests, storage access, or URL navigation patterns found. No secrets or security-sensitive production logic changed.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@mtrezza
mtrezza merged commit 3e689a7 into parse-community:alpha Oct 17, 2026
11 checks passed
@mtrezza
mtrezza deleted the refactor/microlink-react-json-view-1.31.40 branch October 17, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant