Repository navigation
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
Pull Request
Issue
Closes #3478
Approach
Bumps
@microlink/react-json-viewfrom 1.31.22 to 1.31.40 (pinned exactly). It also adds tests in a separate commit before the upgrade. Until now, no tests covered this dependency. The tests pass with both 1.31.22 and 1.31.40.Usage in this project: only the Playground (
Playground.react.js) imports it. The console output renders logged objects and arrays read-only withcollapsed={2},theme="solarized",name={false},displayObjectSize={false},displayDataTypes={false},enableClipboard={true}and a customstyle, without edit, add or delete callbacks. The console overrides ofconsole.errorandconsole.warnskip messages that includereact-json-view error(isReactJsonError).Tests (
src/lib/tests/PlaygroundJsonView.test.js) render the component with the props of the Playground console output, usingreact-domin jsdom:createdAtandupdatedAtof aParse.ObjectasDateobjects.srclogs the error message thatisReactJsonErrorfilters.Peer dependencies: unchanged,
reactandreact-dom>= 15, which accepts React 19.2.7. No release in this range mentions React 19, and apart from the clipboard text the component source is unchanged. Theengines(node >=17), the dependencies (react-base16-styling,react-lifecycles-compat,react-textarea-autosize) and the entry points (dist/main.js,index.mjs) are also unchanged.Lock file changes: only
node_modules/@microlink/react-json-view1.31.22 → 1.31.40.Changes
GameScoreinstead of"GameScore".showCommaprop to the type definitions (fix(types): add missing showComma prop to type definitions microlinkhq/react-json-view#197). Types only.dist/main.jsnow keeps native ES2015+ syntax (classes, arrow functions, spread) and is about 9 KB smaller (120,982 → 112,000 bytes). The dashboard's webpack build does not transpile this package. The previous bundle already contained ES2020 syntax (??), so the browser requirements do not change.react-textarea-autosize, which checks fordocumentbefore using it, and behaves the same in the browser.OnCopyProps.srcaccepts non-object values (fix(types): allow non-object src in OnCopyProps microlinkhq/react-json-view#211). Types only.Comparing the source of 1.31.22 and 1.31.40,
CopyToClipboard.jsis the only changed source file. The other differences in the published bundle come from the build changes in 1.31.34 and 1.31.39.Breaking Changes
None
Code Changes Required
None. The upgrade is a drop-in replacement. The only code change is the new tests.
Tasks
Summary by CodeRabbit