Use _ instead of @ in the default snapshot file name - #147
Open
CiprianPotor wants to merge 1 commit into
Open
CiprianPotor wants to merge 1 commit into
CiprianPotor wants to merge 1 commit into
Conversation
The @ in the default snapshot name is not handled well by some shells and scripts. Switch to <spec-name>-<spec-version>_<block-hash>.snap and update the docs. Closes paritytech#70
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
When no path is passed to
create-snapshot, the file is named<spec-name>-<spec-version>@<block-hash>.snap. The@is annoying in some shells and scripts, so this switches it to_, e.g.node-268_latest.snap.Changes:
core/src/commands/create_snapshot.rs: default name format and the doc comment onsnapshot_pathcli/main.rsandREADME.md: the example log line, socargo rdme --checkstays happyHeads up: anyone relying on the old default name in scripts will get a different file name. Explicit paths are not affected. Let me know if you'd prefer a different separator.