fix(dispatcher): downgrade response and error payloads to the caller's version - #525
Merged
Merged
Conversation
…s version The frame carried a downgraded version byte while the payload inside kept its own, so a peer that asked in an older version would receive a newer variant it cannot decode. Latent while every payload had one version.
pgherveou
approved these changes
Aug 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frame carried a downgraded version byte while the payload inside kept its own, so a peer that asked in an older protocol version would receive a newer variant it cannot decode. Both the response and the domain-error path were affected.
downgrade_call_errorinframe.rsmaps the domain payload throughFromLatest; framework variants pass through.#![allow(clippy::unit_arg)]because the downgrade is emitted uniformly, including for unit payloads where it is a no-op.