fix(firefox): background.scripts event page, not service_worker (#64)#65
Merged
Conversation
) Firefox doesn't support background.service_worker for MV3 (even 121+) — it rejected install with 'background.service_worker is currently disabled. Add background.scripts.' so the Firefox background never ran. Switch the Firefox manifest to an event-page background (`scripts: [background.js]`, `type: module`); Chrome keeps service_worker in its own manifest. Same background.ts bundle. docs: correct the CLAUDE.md 'MV3 SW parity' claim and the firefox README background label. Closes #64 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64. Firefox refused to install the add-on (background.service_worker is currently disabled. Add background.scripts.) — it doesn't support MV3 service-worker backgrounds. Switched the Firefox manifest to an event-page background (
scripts+type: module) running the samebackground.ts; Chrome keepsservice_worker. Corrected the docs that wrongly claimed Firefox SW parity.Still needs a manual Firefox smoke test (load → set up → save → check repo + background console).
🤖 Generated with Claude Code