Repository navigation
chore: remove external repository option - #231
Merged
Merged
Conversation
…sitory (adapts upstream agrahn#1168)" This reverts commit 4f33963.
…port) This fork syncs only through Git. Storing the password store, and with it passkeys, in shared Documents storage exposes passkey metadata to other apps, undermines the confined passkey file store and can lose access after a reinstall. The option was never released, so no migration is needed. Reverts 0c12eb6 and its passkey storage-root follow-up 4f33963.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the external/shared repository option (
Documents/PasswordStore) that came in with the upstream sync (#228, port of upstream agrahn#1168), before it is ever released.Why
The option is unreleased (only in
[Unreleased]), so no data migration is needed.Changes
0c12eb60(port of upstream external repository option is back agrahn/Android-Password-Store#1168): setting, onboarding visibility screen,getRepositoryDirectory()back tofilesDir/store, previous migration restored.4f33963b: passkey providers use the fixedfilesDir/storeroot again.main, except for edits from other upstream commits ported in chore: sync upstream changes (2026-10-27) #228.CHANGELOG.mdentry removed.docs/upstream-reconciliation.mdmarks external repository option is back agrahn/Android-Password-Store#1168 as skipped (reverted), do not re-adopt. Theupstream-syncskill notes the same.Validation
CI=true ./gradlew lint spotlessCheck test -PslimTests assembleDebugpasses locally.