Skip to content

Fix NumPy Serialization#71

Merged
EZoni merged 8 commits into
pals-project:mainfrom
ax3l:fix-multipole-numpy-serialization
Jun 8, 2026
Merged

Fix NumPy Serialization#71
EZoni merged 8 commits into
pals-project:mainfrom
ax3l:fix-multipole-numpy-serialization

Conversation

@ax3l

@ax3l ax3l commented May 12, 2026

Copy link
Copy Markdown
Member

Fix #67

  • add test with reproducer for MultipoleP
  • add fix for MultipoleP
  • develop a more generic serializer that can be used for any location where we have floats and lists

@ax3l ax3l added bug Something isn't working element parameters element parameters (properties, attributes) labels May 12, 2026
@ax3l ax3l changed the title Test: NumPy Multipole Serialization Fix NumPy Multipole Serialization May 12, 2026
@ax3l ax3l force-pushed the fix-multipole-numpy-serialization branch from ba33f5f to f514cc2 Compare May 12, 2026 18:09
@ax3l ax3l requested a review from EZoni May 12, 2026 19:41
@ax3l

ax3l commented May 12, 2026

Copy link
Copy Markdown
Member Author

cc @ruisardkj @adb-xkc85723 NumPy fix attempt :)

@ax3l ax3l changed the title Fix NumPy Multipole Serialization Fix NumPy Serialization May 13, 2026

@EZoni EZoni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review batch to suggest using pytest's tmp_path fixture to avoid polluting and cleaning the root directory (no try/finally, no os.remove, etc.). I think we should do this in pre-existing tests as well, in a separate PR.

Comment thread tests/test_serialization.py Outdated
Comment thread tests/test_serialization.py Outdated
@EZoni EZoni self-requested a review June 8, 2026 19:18
@EZoni EZoni merged commit b725a20 into pals-project:main Jun 8, 2026
16 checks passed
@EZoni EZoni deleted the fix-multipole-numpy-serialization branch June 8, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working element parameters element parameters (properties, attributes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't use type(numpy.float64) for MagneticMultipoleP parameter

2 participants