fix(cli): improve bin dirs search#1638
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
As discovered in #1623, the path resolution is not as rigorous as originally anticipated, with some situations (e.g., worktrees, or displaced venvs) resulting in Pact Python CLI being unable to discover the bundled binaries. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
fix/improve-bin-dirs-search
branch
from
487b6dd to
33b5541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
In addition to a relative search to
__file__, search the platlib and purelib paths exposed by sysconfig.🚨 Breaking Changes🔥 Motivation
As discovered in #1623, the path resolution is not as rigorous as originally anticipated, with some situations (e.g., worktrees, or displaced venvs) resulting in Pact Python CLI being unable to discover the bundled binaries.
🔨 Test Plan
Unit test
🔗 Related issues/PRs
Fixes #1623