fix: pass http transport first to ffi#1637
Merged
Merged
Conversation
The underlying FFI assigns special significance to the first transport added, which can cause issues if the end-user configures non-HTTP transports first. Signed-off-by: JP-Ellis <josh@jpellis.me>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
====================================
Coverage 74% 74%
====================================
Files 36 36
Lines 4028 4030 +2
====================================
+ Hits 2996 2998 +2
Misses 1032 1032
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Internally pick out the HTTP(S) transport so it is set first.
🚨 Breaking Changes🔥 Motivation
The Pact FFI assigns special significance to the first transport configured, which should be HTTP(S). This is an implementation concern, and therefore is handled internally when setting up all the transports.
🔨 Test Plan
Unit tests added
🔗 Related issues/PRs