Conversation
bnaecker
approved these changes
May 20, 2026
Contributor
bnaecker
left a comment
bnaecker
left a comment
There was a problem hiding this comment.
This looks great thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note, this depends on oxidecomputer/omicron#10447 and oxidecomputer/omicron#10419. It was tested with these commits applied to a local omicron branch, and propolis's dependency on omicron patched to refer to the local branch. I would not expect CI to pass until Omicron is updated.
Note that Crucible disks implement Discard as a no-op. Local disks (for which Discard has an effect) currently do not report any metrics (including these new Discard metrics), which is addressed by #1144.