proposal for separating FM and non-FM support_bundle_creates#10667
Merged
mergeconflict merged 2 commits intoJun 23, 2026
Conversation
hawkw
commented
Jun 23, 2026
Comment on lines
+330
to
+334
| ) -> Pin< | ||
| Box< | ||
| dyn Future<Output = Result<SupportBundle, DbError>> + Send + 'a, | ||
| >, | ||
| >, |
Member
Author
There was a problem hiding this comment.
i don't like that this part must be Box<Pinned>>, but it is sadly necessary because otherwise, the returned Future cannot be constrained to the lifetime of the &'a Connection<DbConnection>. so, sigh. whatever.
Member
Author
There was a problem hiding this comment.
(ironically, we could probably get rid of the box here if we had a trait like
trait InsertSupportBundle<'conn> {
type Future: Future<Output = Result<SupportBundle, DbError> + Send + 'conn;
fn do_that(conn: &'conn Connection, ...) -> Self::Future
}but then it can't be a closure, and being able to close over all the junk without having to go and make a struct and all that is helpful for making this code not absurdly verbose. and this is Nexus so i don't think the box golf is that worthwhile...)
mergeconflict
merged commit 351dd14
into
mergeconflict/fm-sitrepguardedinsert-support-bundles
4 of 16 checks passed
mergeconflict
deleted the
eliza/mergeconflict/fm-sitrepguardedinsert-support-bundles
branch
mergeconflict
added a commit
that referenced
this pull request
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in re: #10535 (comment)