Metrics explorer page design - #3348
Open
benjaminleonard wants to merge 27 commits into
Open
benjaminleonard wants to merge 27 commits into
benjaminleonard wants to merge 27 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
marked this pull request as ready for review
August 25, 2026 20:48
| * | ||
| * Exported for tests; use {@link oxqlAutocomplete} in the editor. | ||
| */ | ||
| export const oxqlCompletionSource = |
…query scope, datum
No point leaving it behind.
They're stable.
There is no such thing as "one representative query". There are three distinct kinds of charts, to say nothing of layout!
Codemirror was putting it behind the active line, making it challenging to see what text you selected (and impossible to tell what whitespace you selected).
fakemonster
reviewed
Sep 14, 2026
This page is already tipped pretty far into "knowing everything about backend implementation details", so I'm just grabbing an easy win here.
Safari has subpixel precision on bounding boxes, so we need slightly more tolerance than exact matching for cursor<->placeholder comparisons. "Within a pixel" seems fair enough to me.
Not sure it needs its own doc link, but the docs do give a _little_ context.
fakemonster
reviewed
Sep 14, 2026
It was camel case!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP