Skip to content

feat(web-app-chat-with-file): add expand/collapse toggle to diff view - #536

Merged
LukasHirt merged 1 commit into
mainfrom
feat/chat-with-file-expand-diff
Jul 29, 2026
Merged

feat(web-app-chat-with-file): add expand/collapse toggle to diff view#536
LukasHirt merged 1 commit into
mainfrom
feat/chat-with-file-expand-diff

Conversation

@LukasHirt

@LukasHirt LukasHirt commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Long diffs in the chat-with-file diff view were capped at a fixed max-height with only internal scrolling, making larger proposed edits hard to review.
  • Adds an Expand/Collapse button below the diff block (shown once a diff exceeds a line-count threshold) that raises the max-height so the full diff can be read without scrolling.

Test plan

  • pnpm --filter web-app-chat-with-file check:types
  • pnpm --filter web-app-chat-with-file lint
  • pnpm --filter web-app-chat-with-file test:unit (110 passed)
  • Manually verify in the running dev environment: propose an edit with a long diff, confirm Expand/Collapse toggles the taller view

Long diffs were capped at a fixed max-height with only internal
scrolling, making it hard to review larger proposed edits. Adds an
Expand/Collapse button below the diff block for diffs beyond a line
threshold, raising the max-height so the full diff can be read without
scrolling.

Signed-off-by: Lukas Hirt <info@hirt.cz>
@LukasHirt
LukasHirt requested a review from a team as a code owner July 27, 2026 17:34
@kw-security

kw-security commented Jul 27, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@LukasHirt
LukasHirt requested a review from dj4oC July 27, 2026 17:34
@LukasHirt LukasHirt self-assigned this Jul 27, 2026
@LukasHirt
LukasHirt merged commit 9b8d04b into main Jul 29, 2026
34 checks passed
@LukasHirt
LukasHirt deleted the feat/chat-with-file-expand-diff branch July 29, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants