fix(web-app-ai-quick-draft-creator): reposition and differentiate draft creation error - #534
Merged
Merged
Conversation
…ft creation error The error banner previously rendered above the description textarea using the same styling as regular body text, making failures like "signal timed out" easy to miss. Move it below the description and output-format fields, right above the action buttons where the failing action lives, and style it with the design system's danger color token to match the convention used in sibling AI extensions (e.g. web-app-ai-sensitive-data-scanner, web-app-ai-smart-file-tagger-qa). Closes #528 Signed-off-by: Lukas Hirt <info@hirt.cz>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
dj4oC
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DraftCreatorModal.vuefrom above the description textarea to just above the action buttons, next to the "Create draft" action that can actually fail.oc-text-errorutility class with a scoped style usingvar(--oc-color-danger, #c00), matching the convention already used in sibling packages (web-app-ai-sensitive-data-scanner's.scan-results-error,web-app-ai-smart-file-tagger-qa's.tag-suggestion-error,web-app-ai-multi-doc-synthesizer's.synthesis-error).role="alert"for accessibility and does not change any error messages or the error-setting logic inuseDraftCreator.ts.tests/unit/components/DraftCreatorModal.spec.tscovering: no banner when there's no error, banner text/role when there is one, correct DOM ordering (after the description/format fields, before the actions), and the existing create-draft happy path.Before
Error text ("signal timed out") rendered as the very first element in the modal, above the "Describe the document you need" label, in the same plain body-text styling as the rest of the content.
After
Error text renders directly above the Cancel/Create draft buttons, styled in the design system's danger color so it's clearly distinguishable from body copy.
Closes #528
Test plan
pnpm --filter web-app-ai-quick-draft-creator check:typespnpm --filter web-app-ai-quick-draft-creator lintpnpm --filter web-app-ai-quick-draft-creator test:unit(16 passed, including 5 new)