docs: remove stale log-window keyboard shortcut#746
Open
DeepDiver1975 wants to merge 1 commit into
Open
Conversation
The F12 / Ctrl-L / Cmd+L keyboard shortcut for opening the log window no longer exists. In the owncloud/client v7.1.0 source the log browser is opened only via the General Settings "Log Settings" button (src/gui/generalsettings.cpp -> slotToggleLogBrowser); no F12/Ctrl+L/ Cmd+L shortcut is bound anywhere in src/. Keep only the menu path. Closes #597 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
commented
Jun 21, 2026
DeepDiver1975
left a comment
Member
Author
There was a problem hiding this comment.
🤖 Automated code review by Claude Code review agent
Approve. Removes the stale btn:[F12] / Ctrl-L / Cmd+L log-window hotkey line from the "Logging to a Temporary Directory" steps, keeping the menu path.
- Verified the removed content is genuinely obsolete: the cited evidence (log browser opened only via General Settings "Log Settings", no hotkey bound in client v7.1.0) is consistent with removing the instruction.
- Surrounding prose is intact: the numbered list now reads cleanly (
. Open the Desktop App.→. Click menu:Settings[Advanced > Log Settings].→The Log Output window opens.). The dangling+ Either ... orcontinuation was correctly removed with it; no orphaned reference remains. - AsciiDoc syntax correct.
Pair consistency: identical diff to the 7.1 companion #745, correct master base, closing keyword Closes #597 carried here. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
btn:[F12]/Ctrl-L/Cmd+Lkeyboard-shortcut instruction from the "Logging to a Temporary Directory" steps introubleshooting.adoc, keeping only the menu path.Why
The hotkey to open the log window no longer exists. Verified against the
owncloud/clientv7.1.0 source: the log browser is opened only via the General Settings "Log Settings" button (src/gui/generalsettings.cpp:79→slotToggleLogBrowser); noF12/Ctrl+L/Cmd+Lshortcut is bound anywhere insrc/.Closes #597
🤖 Generated with Claude Code