docs: fix broken xref to Remove an Account section#737
Merged
Conversation
DeepDiver1975
commented
Jun 21, 2026
DeepDiver1975
left a comment
DeepDiver1975
left a comment
Member
Author
There was a problem hiding this comment.
🤖 Automated code review by Claude Code review agent
Verdict: Approve. Verified the fix against the source on the master branch.
- The target heading
==== Remove an Accountexists atusing.adoc:315. Under Antora's id settings (idprefix='',idseparator='-') this generates the anchorremove-an-account, so the oldxref:removing-an-account[...]did not resolve and the newxref:remove-an-account[...]does. Correct. - Scope is docs-only (1 file, +1/-1); no AsciiDoc syntax broken.
- Minor (non-blocking): the link text still reads "Removing an Account" — that is display text, not the target, so it's harmless, but you may want it to read "Remove an Account" to match the heading.
Pair consistency: Paired with #736 (7.1). Both target master vs 7.1 respectively and apply the identical one-line change. Consistent.
phil-davis
approved these changes
Jun 22, 2026
Contributor
|
Please rebase my current branch onto master. Fetch the latest remote changes, perform a rebase, and push the updated branch using git push --force-with-lease. |
The xref used id `removing-an-account`, but the target heading `==== Remove an Account` generates the anchor `remove-an-account` under Antora's id settings (idprefix='', idseparator='-'), so the link did not resolve. Point the xref at the correct anchor. Closes #725 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
force-pushed
the
fix/725-remove-account-xref
branch
from
e3eb157 to
3fa68e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the broken xref at
using.adoc:309:removing-an-account→remove-an-account.Why
The target heading
==== Remove an Account(using.adoc:315) generates the anchorremove-an-accountunder Antora's id settings (idprefix='',idseparator='-'), notremoving-an-account. The previous xref did not resolve.Closes #725
🤖 Generated with Claude Code