fix(settings): preserve edits made during save - #96
Open
kaluli123123 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@coderabbitai review Please focus on asynchronous save ordering, stale completions, and retry behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
A save completion replaced the entire settings state with the snapshot written to disk. If the user edited another field before the asynchronous save completed, that newer draft was silently overwritten.
The state now tracks edit and save revisions. A completion updates the persisted baseline while retaining a newer draft.
Verification
cargo +nightly fmtcargo clippy --workspace --all-targets --all-features -- -D warningscargo deny checkcargo test --workspace --all-features: 528 passed, 2 ignoredcargo llvm-cov --workspace --all-features --fail-under-lines 80: all tests passed on the repeat run; repository line coverage is 67.79%, below the existing 80% gateNotes
The first coverage run exposed the pre-existing double-click timing flake fixed separately.
cargo denyreports the existing yanked transitive dependenciescore2 0.4.0andspin 0.9.8.