fix(macOS): resolve platform-specific lint failures - #87
Merged
Conversation
kaluli123123
pushed a commit
to kaluli123123/otty
that referenced
this pull request
Aug 23, 2026
Contributor
Author
|
@kemokempo Could you please review and merge this PR before #89? All seven checks pass, the PR is mergeable, and #89 is intentionally stacked on this head so its lint job remains green. After #87 lands, GitHub will remove the two app files from #89's effective diff. |
Contributor
I think you need to rebase with |
kaluli123123
force-pushed
the
fix-macos-pre-existing
branch
from
August 24, 2026 12:22
e5c9abf to
33efe1e
Compare
Contributor
Author
kemokempo
reviewed
Aug 24, 2026
kemokempo
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
otty/toapp/reorganization.The settings tests originally included in this PR are already fixed on
main, so the current diff contains only the remaining macOS lint fixes.Verification on macOS
cargo +nightly fmt: passed.cargo clippy --workspace --all-targets --all-features -- -D warnings: passed.cargo deny check: exited 0 with the existing yankedcore2 0.4.0andspin 0.9.8warnings.cargo test --workspace --all-features: 526 passed, 2 ignored.cargo llvm-cov --workspace --all-features --fail-under-lines 80: exited 1 because workspace line coverage is 67.73%.Before the fix, workspace clippy failed on macOS with the unused
resize_gripsimport, unusedwindowimport, and unuseddirbinding.