Skip to content

fix(macOS): resolve platform-specific lint failures - #87

Merged
kemokempo merged 2 commits into
otty-shell:mainfrom
kaluli123123:fix-macos-pre-existing
Aug 25, 2026
Merged

fix(macOS): resolve platform-specific lint failures#87
kemokempo merged 2 commits into
otty-shell:mainfrom
kaluli123123:fix-macos-pre-existing

Conversation

@kaluli123123

@kaluli123123 kaluli123123 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Guard macOS-only unused imports after the repository's otty/ to app/ reorganization.
  • Consume the macOS-only resize direction binding explicitly.
  • Keep the non-macOS resize behavior unchanged.

The settings tests originally included in this PR are already fixed on main, so the current diff contains only the remaining macOS lint fixes.

Verification on macOS

  • cargo +nightly fmt: passed.
  • cargo clippy --workspace --all-targets --all-features -- -D warnings: passed.
  • cargo deny check: exited 0 with the existing yanked core2 0.4.0 and spin 0.9.8 warnings.
  • cargo test --workspace --all-features: 526 passed, 2 ignored.
  • cargo llvm-cov --workspace --all-features --fail-under-lines 80: exited 1 because workspace line coverage is 67.73%.

Before the fix, workspace clippy failed on macOS with the unused resize_grips import, unused window import, and unused dir binding.

kaluli123123 pushed a commit to kaluli123123/otty that referenced this pull request Aug 23, 2026
@kaluli123123 kaluli123123 changed the title fix: resolve pre-existing lint and test failures on macOS fix(macOS): resolve platform-specific lint failures Aug 23, 2026
@kaluli123123

Copy link
Copy Markdown
Contributor Author

@kemokempo Could you please review and merge this PR before #89? All seven checks pass, the PR is mergeable, and #89 is intentionally stacked on this head so its lint job remains green. After #87 lands, GitHub will remove the two app files from #89's effective diff.

@kemokempo

Copy link
Copy Markdown
Contributor

@kemokempo Could you please review and merge this PR before #89? All seven checks pass, the PR is mergeable, and #89 is intentionally stacked on this head so its lint job remains green. After #87 lands, GitHub will remove the two app files from #89's effective diff.

I think you need to rebase with main first

@kaluli123123
kaluli123123 force-pushed the fix-macos-pre-existing branch from e5c9abf to 33efe1e Compare August 24, 2026 12:22
@kaluli123123

Copy link
Copy Markdown
Contributor Author

Rebased both branches onto the current main with linear history. #87 now points directly to one commit on dab418d, and #89 is stacked linearly on #87. The resulting file trees are unchanged; CI is rerunning on the rewritten heads.

Comment thread app/src/events/mod.rs Outdated
Comment thread app/src/events/mod.rs
@kemokempo
kemokempo merged commit 8f9dcdd into otty-shell:main Aug 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants