Skip to content

NO-ISSUE: let ci-duty manage the GitHub Apps of the org - #301

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:ci-duty-app-manager
Nov 21, 2026
Merged

eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:ci-duty-app-manager

Conversation

@eliorerz

@eliorerz eliorerz commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Assigns GitHub's predefined App manager organization role to the ci-duty team, so its members can register and manage the GitHub Apps the organization owns (the OSAC CI app, for example) without being organization owners.

What the role allows, and does not. App managers manage the settings of the GitHub Apps registered under the organization (About GitHub App managers). It does not let them install or uninstall an app on the organization, or list an app in the Marketplace: an organization owner does that.

How. The same pattern as the CI/CD admin role of this team in organization.tf: the predefined role is looked up in data.github_organization_roles.all and assigned with github_organization_role_team. The name is not guessed this time: gh api /orgs/osac-project/organization-roles lists the role as app_manager (id 33679, source Predefined), and the lookup matches that exact name. If it ever stopped matching, one([]) would be null and the plan would fail instead of assigning another role. README.md lists it with the other roles of the team.

Team. I took "the OSAC CI team" to be ci-duty, the team that already holds CI/CD admin, the ci-maintainer repository role and the bypass on the CI repositories. If it should be another team (wg-infra, for example), only the team_slug changes.

To check after the apply: gh api /orgs/osac-project/organization-roles/33679/teams lists ci-duty; a member of the team can register an app under Organization settings → Developer settings → GitHub Apps. (The docs do not say outright that the role lets a manager register a new app, only that it lets them manage the org's apps, so that is the one thing to try.)

Not run: tofu fmt and tofu validate. tofu is not installed where this was prepared, so the hook failed locally; the code follows the formatting of the neighbouring blocks, and the pre-commit and plan workflows of this repository run them.

Affected area: GitHub organization configuration (OpenTofu) and documentation. No API, controller, database, runtime, or test changes.

organization.tf (+19) looks up the predefined app_manager organization role by exact name with one([]), then assigns it to the ci-duty team with github_organization_role_team. README.md (+4) documents the role.

Backward compatibility: applying the change grants ci-duty members App manager rights on the org. No code compatibility impact.

Risk classification: not available. The risk:ship, risk:show, and risk:ask labeling instructions were not retrieved. Shell log reads returned only further log paths, so no criteria could be checked.

Assign GitHub's predefined App manager organization role to the
ci-duty team, so it can register and manage the GitHub Apps the
organization owns (the OSAC CI app) without being org owners. The
role does not let them install an app or list it in the Marketplace:
an organization owner does that.

Signed-off-by: Elior Erez <eerez@redhat.com>
@eliorerz
eliorerz requested a review from a team November 21, 2026 17:52
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

The organization configuration assigns GitHub’s predefined app_manager role to the ci-duty team. The README documents the role’s stated permissions and limits.

Changes

App manager role assignment

Layer / File(s) Summary
Select and assign the role
organization.tf, README.md
The configuration selects the predefined app_manager role by exact name and assigns its ID to ci-duty. The README describes the role’s permissions and limits.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested labels: risk:ask

Suggested reviewers: eranco74

Merge Risk: Minimal · up to 2e103

This grants the ci-duty team GitHub's App manager role so its members can manage the organization's GitHub Apps without being owners. The change is small and easy to revert. The only residual uncertainty is whether the role name matches what the GitHub API returns, and the plan workflow would fail visibly before apply if it did not. No merge-blocking risk was found.

Pre-merge checks: Passed 10

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "NO-ISSUE: let ci-duty manage the GitHub Apps of the org" matches the main change. The PR assigns GitHub's predefined app_manager organization role to the ci-duty team, which lets members re…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets Passed The reviewed diff changes two files: README.md (documentation lines only) and organization.tf (a new locals block and a github_organization_role_team resource). I read the full patch. It contains no A…
No-Weak-Crypto Passed The check is not applicable to this change. The PR (#301, eliorerz, osac-project/github-config) changes only README.md and organization.tf. It adds a GitHub organization role assignment: a local tha…
No-Injection-Vectors Passed The pull request changes two files: README.md (documentation only) and organization.tf (OpenTofu/HCL). The diff adds a locals block that selects the app_manager role ID from `data.github_organizat…
Container-Privileges Passed The check is not applicable. The container-privileges check targets container and Kubernetes manifests. This PR changes only two files: README.md (+4/-0) and organization.tf (+19/-0). Both are GitHub …
No-Sensitive-Data-In-Logs Passed The check looks for logging that could expose passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data. The PR changes only two files: README.md (+4 lines of documentation) …
Ai-Attribution Passed The ai-attribution check applies only when AI tools were used and that use is mentioned in the PR or its commits. Neither source mentions AI tool use. - Commit: the single head commit (2e1037a, by Eli…
Full details: Title check

Explanation

The title "NO-ISSUE: let ci-duty manage the GitHub Apps of the org" matches the main change. The PR assigns GitHub's predefined app_manager organization role to the ci-duty team, which lets members register and manage org-owned GitHub Apps without becoming organization owners. The title is specific and short, and it names the team and the purpose. The "NO-ISSUE" prefix is a tracking tag and does not affect the assessment.

Full details: No-Hardcoded-Secrets

Explanation

The reviewed diff changes two files: README.md (documentation lines only) and organization.tf (a new locals block and a github_organization_role_team resource). I read the full patch. It contains no API keys, tokens, passwords, private keys, base64 blobs, or URLs with embedded credentials. No variable named api_key, secret, token, or password is assigned a string literal. The role ID is computed at plan time from data.github_organization_roles.all by matching the name "app_manager", so it is not a hardcoded value. The check's exception for test files is not needed here. The check passes.

Full details: No-Weak-Crypto

Explanation

The check is not applicable to this change. The PR (#301, eliorerz, osac-project/github-config) changes only README.md and organization.tf. It adds a GitHub organization role assignment: a local that picks the predefined app_manager role ID, and a github_organization_role_team resource that binds it to the ci-duty team. The diff contains no hashing, symmetric or block cipher, random-token handling, custom cryptography, or secret comparison. I searched the diff for MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, cipher, HMAC, hash, and encryption terms. The only match was the == in the role-name filter r.name == "app_manager", which compares role metadata, not a secret or token.

Full details: No-Injection-Vectors

Explanation

The pull request changes two files: README.md (documentation only) and organization.tf (OpenTofu/HCL). The diff adds a locals block that selects the app_manager role ID from data.github_organization_roles.all with a for expression and one([]), plus a github_organization_role_team resource. None of the flagged patterns appear in the diff: no SQL string concatenation, no shell=True or os.system, no eval/exec, no pickle.loads, no yaml.load, no dangerouslySetInnerHTML. The jq exception does not apply because no jq filter string is built. The role name comes from a fixed literal in the configuration, not from user input. The check passes.

Full details: Container-Privileges

Explanation

The check is not applicable. The container-privileges check targets container and Kubernetes manifests. This PR changes only two files: README.md (+4/-0) and organization.tf (+19/-0). Both are GitHub organization configuration for a GitHub App manager role assignment. A search of both changed files for privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, runAsUser, and allowPrivilegeEscalation found no matches. No container or Kubernetes manifest is changed, so no listed privilege condition is introduced.

Full details: No-Sensitive-Data-In-Logs

Explanation

The check looks for logging that could expose passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data. The PR changes only two files: README.md (+4 lines of documentation) and organization.tf (+19 lines). The diff adds a locals block that looks up the app_manager role ID and a github_organization_role_team resource that assigns it to ci-duty. The diff contains no logging, print, echo, output, or debug statements. A grep of added lines for log, print, echo, output, debug, token, secret, password, email, and similar terms found no matches. Nothing in the change emits or logs sensitive data, so the check passes.

Full details: Ai-Attribution

Explanation

The ai-attribution check applies only when AI tools were used and that use is mentioned in the PR or its commits. Neither source mentions AI tool use. - Commit: the single head commit (2e1037a, by Elior Erez) has a plain message with a Signed-off-by trailer. It has no Assisted-by, Generated-by, or Co-Authored-By trailer. A case-insensitive search of the message for AI tool names and attribution keywords found nothing. - PR description: it describes the role assignment, the lookup, the team choice, and the untested tofu fmt/tofu validate step. It does not mention AI tools. - Raw summary: the "AI-generated summary" wording comes from the review tooling that describes the diff. It is not a statement by the PR author that AI tools were used to write the change. No AI tool use is recorded, so no Red Hat attribution trailer is required. The absence of a trailer is not a failure here.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: f4688dec-e080-4e4d-bbc6-299c8198b230
Commits

Reviewing files that changed from the base of the PR and between ec3b8d9 and 2e1037a.

Files selected for processing: 2

  • README.md
  • organization.tf

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@eliorerz
eliorerz merged commit 9f8922d into osac-project:main Nov 21, 2026
2 checks passed
@eliorerz
eliorerz deleted the ci-duty-app-manager branch November 21, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant