Skip to content

feat: delete identity doc - #2694

Open
vinckr wants to merge 2 commits into
masterfrom
vinckr/docs-janitor-0077
Open

feat: delete identity doc#2694
vinckr wants to merge 2 commits into
masterfrom
vinckr/docs-janitor-0077

Conversation

@vinckr

@vinckr vinckr commented Jul 27, 2026

Copy link
Copy Markdown
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Summary by CodeRabbit

  • Documentation
    • Added the “Delete User Identities” guide to the Identity Management section of the Identity & AuthN documentation.

@vinckr
vinckr requested a review from aeneasr as a code owner July 27, 2026 10:54
Copilot AI review requested due to automatic review settings July 27, 2026 10:54
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6981a4f5-a486-4e71-b926-3c6d89ff158e

📥 Commits

Reviewing files that changed from the base of the PR and between 1f13ed7 and c754522.

⛔ Files ignored due to path filters (2)
  • docs/kratos/manage-identities/21_delete-users-identities.mdx is excluded by !**/*.mdx
  • docs/kratos/self-service/flows/user-settings.mdx is excluded by !**/*.mdx
📒 Files selected for processing (1)
  • sidebars-network.ts

📝 Walkthrough

Walkthrough

The network sidebar now includes the kratos/manage-identities/delete-users-identities document under the “Identity management” section of “Identity & AuthN”.

Changes

Network sidebar navigation

Layer / File(s) Summary
Add identity deletion navigation entry
sidebars-network.ts
Adds the delete-users-identities document to the Identity management sidebar category.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • ory/docs#2589: Updates the same network sidebar with an additional navigation entry.

Suggested reviewers: copilot, hperl, aeneasr

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is only the template and lacks a real summary, issue/design link, checklist marks, and any further comments. Replace the template text with a filled PR description that explains the change, links any related issue, and completes the relevant checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the identity-doc/sidebar change and clearly signals the update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vinckr/docs-janitor-0077

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds documentation for deleting identities in Ory Network, wires it into the Network sidebar, and cross-links it from the settings-flow docs to clarify that account deletion is an admin (not self-service) operation.

Changes:

  • Add a new “Delete identities” guide under Kratos → Manage identities (Network-focused).
  • Add the new page to sidebars-network.ts navigation.
  • Add a note in the user settings flow docs pointing readers to the new deletion guide.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
sidebars-network.ts Adds the new “Delete identities” doc to the Network sidebar navigation.
docs/kratos/self-service/flows/user-settings.mdx Adds a note clarifying deletion is not part of the settings flow and links to the new guide.
docs/kratos/manage-identities/21_delete-users-identities.mdx Introduces a new guide describing admin-driven identity deletion and considerations for self-service “delete my account” UX.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/kratos/manage-identities/21_delete-users-identities.mdx Outdated
Comment thread docs/kratos/self-service/flows/user-settings.mdx Outdated

@unatasha8 unatasha8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants