Skip to content

fix(property-dropdown): align pill pickers before reveal - #1237

Merged
Chloe-JY merged 2 commits into
developfrom
dev/fix-property-dropdown-alignment
Sep 3, 2026
Merged

fix(property-dropdown): align pill pickers before reveal#1237
Chloe-JY merged 2 commits into
developfrom
dev/fix-property-dropdown-alignment

Conversation

@sudomaggie

@sudomaggie sudomaggie commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Problem

Pill-style property pickers initially rendered left-aligned, then shifted to their trailing edge after the panel measured itself. Eleven Project and Work Item pickers passed align="auto", so the incorrect first placement could be visible before the final right-aligned position.

Solution

Add one shared pill-alignment helper that resolves pill fields to the trailing/right edge and update every affected picker to use it. The shared dropdown surface now uses the established positioned-overlay visibility utility, so callers that still require auto placement remain hidden and non-interactive until measurement selects their final side. Regression coverage verifies the right-edge policy and an auto-aligned menu's resolved portal styles.

  • Updated the Team Inbox test harness to preserve the real Git-remotes module exports while overriding only getGitRemotes; this prevents the PR import graph from exposing a stale full-module mock during full-suite collection.

Potential risks

Right-aligned pill menus near the viewport's far left have less room on their left edge than the prior auto-placement behavior. The existing menu sizing and portal behavior are otherwise unchanged; no data, API, persistence, concurrency, or lifecycle behavior changes. Rollback is a revert of this single commit.

  • The CI repair changes only a Vitest mock boundary; production code and runtime behavior are unaffected.

Verification

  • GitHub Actions CI run 33753170346 → frontend passed; Rust jobs were correctly skipped by scope

  • ../../../node_modules/.bin/vitest run --config config/vitest.config.ts src/modules/MainApp/TeamInbox/__tests__/AssignedWorkItemDetail.test.ts --reporter=verbose9/9 passed, 0 failed

  • ../../../node_modules/.bin/eslint src/modules/MainApp/TeamInbox/__tests__/AssignedWorkItemDetail.test.ts --max-warnings 0 --report-unused-disable-directives → clean

  • ../../../node_modules/.bin/tsgo --noEmit --pretty false → clean

  • node scripts/quality/check-test-placement.mjs → consistent across 457 directories

  • pnpm test -- src/components/PropertyField/PropertyFieldEditable.test.ts src/components/PropertyField/PropertyDropdownField.test.ts src/modules/ProjectManager/WorkItems/components/WorkItemProperties/PlanningSection.test.ts — 13 tests passed

  • pnpm lint:file src/components/PropertyField/PropertyFieldEditable.tsx src/components/PropertyField/PropertyFieldEditable.test.ts src/modules/ProjectManager/WorkItems/components/WorkItemProperties/DateQuickAssignDropdown.tsx src/modules/ProjectManager/WorkItems/components/WorkItemProperties/LabelsSection.tsx src/modules/ProjectManager/WorkItems/components/WorkItemProperties/PlanningSection.tsx src/modules/ProjectManager/shared/components/PropertiesPanel/PropertyFieldSections/PeopleTeamsLabelsFields.tsx src/modules/ProjectManager/shared/components/PropertiesPanel/PropertyFieldSections/StatusHealthPriorityFields.tsx — passed

  • pnpm typecheck:fast — passed

  • git diff --check origin/develop...HEAD — passed

  • No live screenshot or recording: desktop UI control was not authorized for this task. The added JSDOM regression test verifies the resolved right-edge styles and visibility state.

Audit

  • docs/frontend-ui-audit-2026-09-03/PropertyDropdownAlignment.md — 0 fix, 9 keep with reason, 0 abstract

@Chloe-JY
Chloe-JY merged commit b244572 into develop Sep 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants