fix(property-dropdown): align pill pickers before reveal - #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pill-style property pickers initially rendered left-aligned, then shifted to their trailing edge after the panel measured itself. Eleven Project and Work Item pickers passed
align="auto", so the incorrect first placement could be visible before the final right-aligned position.Solution
Add one shared pill-alignment helper that resolves pill fields to the trailing/right edge and update every affected picker to use it. The shared dropdown surface now uses the established positioned-overlay visibility utility, so callers that still require auto placement remain hidden and non-interactive until measurement selects their final side. Regression coverage verifies the right-edge policy and an auto-aligned menu's resolved portal styles.
getGitRemotes; this prevents the PR import graph from exposing a stale full-module mock during full-suite collection.Potential risks
Right-aligned pill menus near the viewport's far left have less room on their left edge than the prior auto-placement behavior. The existing menu sizing and portal behavior are otherwise unchanged; no data, API, persistence, concurrency, or lifecycle behavior changes. Rollback is a revert of this single commit.
Verification
GitHub Actions CI run 33753170346 → frontend passed; Rust jobs were correctly skipped by scope
../../../node_modules/.bin/vitest run --config config/vitest.config.ts src/modules/MainApp/TeamInbox/__tests__/AssignedWorkItemDetail.test.ts --reporter=verbose→ 9/9 passed, 0 failed../../../node_modules/.bin/eslint src/modules/MainApp/TeamInbox/__tests__/AssignedWorkItemDetail.test.ts --max-warnings 0 --report-unused-disable-directives→ clean../../../node_modules/.bin/tsgo --noEmit --pretty false→ cleannode scripts/quality/check-test-placement.mjs→ consistent across 457 directoriespnpm test -- src/components/PropertyField/PropertyFieldEditable.test.ts src/components/PropertyField/PropertyDropdownField.test.ts src/modules/ProjectManager/WorkItems/components/WorkItemProperties/PlanningSection.test.ts— 13 tests passedpnpm lint:file src/components/PropertyField/PropertyFieldEditable.tsx src/components/PropertyField/PropertyFieldEditable.test.ts src/modules/ProjectManager/WorkItems/components/WorkItemProperties/DateQuickAssignDropdown.tsx src/modules/ProjectManager/WorkItems/components/WorkItemProperties/LabelsSection.tsx src/modules/ProjectManager/WorkItems/components/WorkItemProperties/PlanningSection.tsx src/modules/ProjectManager/shared/components/PropertiesPanel/PropertyFieldSections/PeopleTeamsLabelsFields.tsx src/modules/ProjectManager/shared/components/PropertiesPanel/PropertyFieldSections/StatusHealthPriorityFields.tsx— passedpnpm typecheck:fast— passedgit diff --check origin/develop...HEAD— passedNo live screenshot or recording: desktop UI control was not authorized for this task. The added JSDOM regression test verifies the resolved right-edge styles and visibility state.
Audit
docs/frontend-ui-audit-2026-09-03/PropertyDropdownAlignment.md— 0 fix, 9 keep with reason, 0 abstract