docs: track what the three-way review turned into, and gate CSS - #228
Merged
Conversation
Adds a progress section to docs/THREE_WAY_REVIEW.md rather than editing the 2026-08-02 snapshot: letting an assessment quietly reshape itself around what got built is the drift it complains about. Records what landed, what was deliberately left, and five things the implementation found that the review had missed — including that `deepcode --version` had printed 0.1.0 on every release, and that the macOS sandbox denied reads of the workspace itself. Also adds `css` to the prettier globs. A stylesheet postcss cannot parse passed `format:check` (which covered ts/tsx/json/md/yml/yaml only); a rebase seam produced exactly that, and only the Playwright journey caught it. index.css was already clean, so this is a gate change with no reformatting. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap-up for the batch that came out of #216.
Progress section, not a rewrite
docs/THREE_WAY_REVIEW.md§4 stays as the 2026-08-02 snapshot it says it is. A new §7 records what landed (F1–F7, F9–F12, F14 + the desktop palette), what was deliberately left (F13 — DeepSeek has no vision backend), and what is still open (F8 structured-item resume, F15 protocolthread/list/fork/archive, reasoning still dropped in the desktop, Linux bwrap not empirically re-tested).Letting an assessment quietly reshape itself around what got built is exactly the drift it complains about.
Five things the implementation found that the review missed
Recorded in the same section, because they say something about where to look next:
deepcode --versionprinted0.1.0on every release — it reads core'sVERSION, which the release workflow never stamped(deny default)with no cwd rule, while Linux bound cwd read-writereview_actioncarrieskind: 'apply', which clobberedkind: 'event'; invisible because there were no consumersformat:checkdidn't cover.cssThe CSS gate
cssjoins the prettier globs.index.csswas already clean, so this is a gate change with no reformatting — verified by appending an unclosed rule and watchingformat:checkfail, then reverting.🤖 Generated with Claude Code