chore(deps): Bump react-dom and @types/react-dom - #171
Conversation
dependabot
Bot
added
dependencies
|
@dependabot rebase |
Bumps [react-dom](https://github.com/react/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.2.8 - [Release notes](https://github.com/react/react/releases) - [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/react/react/commits/v19.2.8/packages/react-dom) Updates `@types/react-dom` from 18.3.7 to 19.2.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-version: 19.2.3 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: react-dom dependency-version: 19.2.7 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
4d7010c to
e0b57c4
Compare
Review: superseded by #211 — cannot merge as-isSame coupling problem as #170, from the other side: this bumps Both are also missing the code change React 19 needs — its #211 lands react, react-dom, both Closing in favour of #211. |
|
Superseded by #211. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
…fix (#211) Supersedes #170 and #171, which each bump only half the pair and cannot merge independently — react@19 with react-dom@18 (or vice versa) is a broken tree. React 19's @types/react removes the global `JSX` namespace; it now lives under `React.JSX` and is re-exported as a named type from 'react'. 38 `JSX.Element` references across 25 desktop files were resolving against the old global and fail with TS2503 under the new types. Each file now imports the type explicitly, merged into its existing 'react' import where one exists so no duplicate-import lint warning is introduced (root lint is --max-warnings=0 as of #210). Verified with a forced rebuild (`tsc -b --force`) rather than an incremental one — `tsc -b` reuses .tsbuildinfo and silently skips the desktop project, which masks exactly this class of failure. - tsc -b --force, lint (--max-warnings=0), format:check: clean - 1033 tests across 8 packages: pass - pnpm build: pass - desktop Playwright protocol journey (4 tests): pass Co-authored-by: t <t@t> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 participant
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.3.1 to 19.2.8Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
1dd4ecb[FlightReply] Performance improvements when decoding (#37087)b0d2fdb[19.2.x] Update required references to GitHub repo (#36753)6117d7cVersion 19.2.7 (#36591)eaf3e95Version 19.2.623f4f9f19.2.590ab3f8Version 19.2.4612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.18618113Bump scheduler version (#34671)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react-dom since your current version.
Updates
@types/react-domfrom 18.3.7 to 19.2.3Commits