fix(web): identical hit area for the mail-connect modal buttons - #340
Open
oratis wants to merge 1 commit into
Open
fix(web): identical hit area for the mail-connect modal buttons#340oratis wants to merge 1 commit into
oratis wants to merge 1 commit into
Conversation
…al hit area "Open Google App Passwords" (.mm-link) and "Connect" (.dm-start) were different sizes (12.5px/6px-12px vs 13px/8px-16px), so their click areas did not match. Match .mm-link to .dm-start's box, drop an inline-flex that made the <a> ~0.5px shorter than the <button>, and pin both to line-height:1.2 for exact parity. Measured in-browser: both 33.59px, identical padding/font/line-height. Snapshot refreshed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connect-mailbox modal has two accent action buttons — "Open Google App
Passwords ↗" (
.mm-link) and "Connect →" (.dm-start) — that werevisibly different sizes, so their click/hit areas didn't match:
.mm-link(before)6px 12px.dm-start8px 16pxMatched
.mm-linkto.dm-start's box. Two follow-on details:inline-flexI first added to.mm-link— an<a>renders it~0.5px shorter than a
<button>under flex cross-sizing.line-height: 1.2(a font-independent ratio) to erase the lastsub-pixel
<a>-vs-<button>gap. The.dm-startchange is a ~0.1px no-opvisually and makes its box explicit rather than UA-dependent.
Verification
Rendered the real
MAIN_HTMLand measured both buttons in-browser:MAIN_HTMLsnapshot refreshed;tsc --noEmitclean; full suite 1542 pass / 0 fail.