Skip to content

fix: improve mobile admin layouts - #107

Merged
orangeboyChen merged 6 commits into
mainfrom
codex/fix-mobile-admin-layouts
Sep 4, 2026
Merged

fix: improve mobile admin layouts#107
orangeboyChen merged 6 commits into
mainfrom
codex/fix-mobile-admin-layouts

Conversation

@orangeboyChen

Copy link
Copy Markdown
Owner

Summary

  • prevent long account credential filenames from pushing refresh controls outside cards
  • stack account status actions on narrow screens for cleaner check-in layout
  • keep long debug credential labels wrapping within mobile entry width
  • keep admin header fixed while scrolling and offset console content

Verification

  • bun run lint
  • bun run format:check
  • bun run typecheck
  • bun run test:coverage (93.81% statements, 94.39% lines)
  • bunx next build --webpack
  • mobile viewport checked at 360x800 in browser

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 576cbe8642

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

</Tooltip>
<Tooltip title={credential.filename}>
<Text ellipsis type="secondary">
<Text className="account-status-card-filename" type="secondary">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retain filename containment above 767px

At viewport widths of 768px or more, none of the new .account-status-card-* overflow rules apply, but this line removes ellipsis unconditionally. Because /admin-api/credentials accepts caller-supplied basename-only filenames without a length limit, a long unbroken filename can retain its intrinsic width on tablet or desktop and overflow the card or displace the Refresh button; keep truncation outside the mobile breakpoint or apply the min-width/wrapping constraints at every width.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.77%. Comparing base (f3c94cb) to head (09500e9).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          21       21           
  Lines        4251     4251           
  Branches     1238     1238           
=======================================
  Hits         4029     4029           
  Misses        222      222           
Flag Coverage Δ
unittests 94.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orangeboyChen
orangeboyChen enabled auto-merge (squash) September 4, 2026 08:10
@orangeboyChen
orangeboyChen merged commit 7845b54 into main Sep 4, 2026
7 checks passed
@orangeboyChen
orangeboyChen deleted the codex/fix-mobile-admin-layouts branch September 4, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant