Repository navigation
Conversation
The constructor took only cls, so _thread.RLock(0) and threading.RLock(0) raised TypeError. CPython 3.12 and 3.13 accept and ignore any arguments, and threading.RLock passes them on after a DeprecationWarning that announces the removal for 3.15. Signed-off-by: Jeongseop Lim <jeongseop_lim@korea.ac.kr>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1258
_thread.RLock()took onlycls, so any argument raisedTypeError, andthreading.RLock(0)raised it right after its ownDeprecationWarning. CPython'srlock_newtakesargsandkwdsand never reads them (_threadmodule.c#L1198-L1217); onlythreading.RLockwarns, and the arguments are rejected starting in 3.15.AS-IS
TO-BE
(matching CPython)
Changes
RLockBuiltins.ConstructRLockNodewithtakesVarArgsandtakesVarKeywordArgsand ignore the extra arguments, asTeeDataObjectBuiltins.TeeDataObjectNodedoes.test_rlock_new_ignores_argumentstotests/test_threading.py.Testing
mx python-jvmon darwin-aarch64, thenmx graalpytest test_threading.py(6 passed, 1 skipped).test.test_threading(164 passed) andtest.test_thread(26 passed) fromlib-pythonpass. The new test fails on the unpatched build._thread.RLockandthreading.RLockwith and without arguments, reentrant acquire and release, and a subclass now print the same as CPython 3.13.14.