Repository navigation
Conversation
The tp_new signature declared no minimum and no positional-only parameters, so _tuplegetter(0) and _tuplegetter() built a descriptor from defaults, and index and doc were accepted as keywords. CPython requires exactly two positional arguments and rejects keywords. Signed-off-by: Jeongseop Lim <jeongseop_lim@korea.ac.kr>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1249
The
tp_newsignature of_collections._tuplegetterdeclaredindexanddocwith no minimum and no positional-only count, so a call with fewer than two arguments built a getter for index0, and both arguments could be passed by keyword. CPython'stuplegetter_newrejects keywords and requires exactly two positional arguments (_collectionsmodule.c.h#L607-L613).AS-IS
TO-BE
(matching CPython's exception type; the messages are GraalPy's usual argument errors)
Changes
minNumOfPositionalArgs = 3, numOfPositionalOnlyArgs = 3to the@SlotSignatureofTupleGetterBuiltins.TupleGetterNode.test_tuplegetter_argumentstotests/test_collections.py.Testing
mx python-jvmon darwin-aarch64, thentests/test_collections.py(2 passed). The new test fails on the unpatched build._tuplegetter(0, None)still creates the getter,_tuplegetter(1, 'd').__get__((10, 20))returns20, andnamedtuplefield access and field docs work as before.