Repository navigation
fix(frontend): interpolate the loaded-record count in the node session panel - #235
Merged
Merged
Conversation
…n panel
The copy asked for {{records}} while the caller passed count, so i18next
left the placeholder unresolved in both locales. Use the count variable
the call site already provides and assert the interpolated text in the
component test for zh-CN and en-US.
Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
节点详情「会话」区底部的计数文案一直显示未插值的占位符
{{records}}（中英文都是）。文案用的是{{records}}，调用处传的是count（run-node-session.tsx:149），i18next 找不到records，就把占位符原样输出。本 PR 把中英文两条文案的
{{records}}改成 i18next 内置的{{count}}，调用处不动；与仓库里其他计数文案（如history-translations.ts）保持一致。Evidence
After: 中文「已加载 5 条记录」，英文「5 records loaded」。
run-node-session.test.tsx新增中英文两条用例，断言插值后的完整文本，并断言区域内不再出现{{。{{records}}，两条用例失败；把调用处改成{ records: … }，两条用例同样失败（验证后均已恢复）。task frontend:check通过（格式、lint、类型、测试、模块检查、死代码、重复、构建）。ADR
不涉及 ADR。
Refs ora-space/circus#805
🤖 Generated with Claude Code