Skip to content

ci: ship the Agent declaration with every release - #7

Merged
EricWvi merged 1 commit into
ora-space:mainfrom
ObsisMc:ci/370-enable-agent-configuration
Oct 22, 2026
Merged

EricWvi merged 1 commit into
ora-space:mainfrom
ObsisMc:ci/370-enable-agent-configuration

Conversation

@ObsisMc

@ObsisMc ObsisMc commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Refs ora-space/circus#370

What

release.yml now passes --agent-configuration to deno task package. From the next tag on, every .orax carries assets/config.json (declaration digest 2d1afa5e…53c1), the release manifest gains its [agent_configuration] section, and agent-configuration.json is attached to the release and copied into the marketplace registry entry.

AGENTS.md and the step comment are updated to say the flag is on. Nothing else changes: the packaging script, the declaration bytes and the pinned digest test are untouched.

Why now

The owner decided to turn on the Claude switch only (OpenCode stays off). The hosts that resolve the declaration (desktop#708, cloud#106) are merged, and acceptance runs on a pinned-main cluster stack.

Before merging

Desktop v0.4.0 (the latest desktop release) predates the agent-declaration compiler: its plugin-config compiles assets/config.json only as the Settings, MCP or Hook shape. A desktop on v0.4.0 would install a package from a release built with this flag, then refuse to activate it.

  • Releases are created automatically: by a pushed tag, and by the nightly upstream.yml whenever a new claude-agent-acp appears.
  • A release does not reach users by itself. marketplace.yml only opens a PR on ora-space/marketplace, and a human merges it. That merge is the last gate.

So either merge this after a desktop release that contains desktop#708, or merge it now and hold the marketplace PRs until then.

Verification

  • deno task test: 45 passed.
  • deno fmt --check AGENTS.md passes.
  • A local deno task package --agent-configuration build of main 8115695 is what the formal acceptance in circus#370 installs. Results will be reported there.

ADR

No ADR status change in this PR. Both ADRs this release depends on, decisions/node/agent-runtime/20261017-plugin-owned-model-adapters.md and decisions/cloud/model-access/20261017-personal-agent-configurations.md, are already implemented: ora-space/specs#198 merged on 2026-10-22 after the formal acceptance in circus#370 passed. No further specs PR is needed for this change.

Pass --agent-configuration to the package step so each .orax carries
assets/config.json and the release manifest binds it. The owner turned
the switch on once the hosts that resolve the declaration were accepted.

@wanglongan587 wanglongan587 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve(审过 e8da0edc5c01be99082b975b8f1bbf272fa8282b)

审的是 ci: ship the Agent declaration with every release 这一个提交的完整 diff:

  • release.yml 只把 deno task package 加上 --agent-configuration,与 #370 正式验收栈里实际安装的包是同一组打包参数;AGENTS.md 和步骤注释同步说明开关已打开,没有改打包脚本、声明字节或固定摘要测试。
  • CI check、argv 均通过;argv 这条正好守住 #452 要求的"发布令牌不进命令行"。
  • 描述里写了与 ADR 的关系:本 PR 不改 ADR 状态,plugin-owned-model-adapters、personal-agent-configurations 仍为 approved,转 implemented 由 circus#467 承接,符合"ADR 状态跟着实现走"。
  • 合并时机(desktop v0.4.0 早于声明编译器,需等含 desktop#708 的 desktop release 或压住 marketplace PR)是 owner 的排期决定,不是这个改动本身的缺陷。

范围说明:我在本机核对了 diff、CI 与描述里引用的三个固定 SHA(cloud 7a48f340、desktop f43f52fc、cluster 8f39f421);aarch64 验收栈上的三项实测结论来自 circus#370 的记录,我没有独立重跑。

@wanglongan587

Copy link
Copy Markdown
Contributor

补充更正:ADR 状态已变(代码结论不变)

审到 e8da0ed 后,specs 侧又有合并:specs#198 已于 2026-10-22 09:27 合并(merge commit 9a415c46,head 261daca),personal-agent-configurations 和 plugin-owned-model-adapters 现在都是 implemented;circus#467 也已在 09:30 关闭。

PR 描述里的这段仍写 "stay approved … tracked in circus#467",与当前状态不符。请更新描述(不改代码);更新后 review:lgtm(e8da0ed)继续有效,不需要重新 review。

另外一条非阻塞的措辞建议:release.yml 新注释说 "A host that cannot compile the declaration installs such a package but then refuses to activate"。这只对不认识 [agent_configuration] 段的旧宿主(例如 desktop v0.4.0)成立;发行绑定声明时,能解析该段但编译不了的宿主在 staging/安装阶段就拒绝(specs#198 的 ADR 已按此改准)。建议把注释收窄到"不认识该段的旧宿主",以免和 ADR 对不上。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants