Skip to content

fix(ci): anchor native-change detection to package.json's version, not the latest tag #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlos-alm merged 2 commits into from
Jul 20, 2026
Merged

fix(ci): anchor native-change detection to package.json's version, not the latest tag #2128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a61845c
fix(ci): anchor native-change detection to package.json's version, no…
carlos-alm Jul 19, 2026
45eadb4
fix: parse package.json version via node -p instead of grep/sed (#2128)
carlos-alm Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,21 @@ jobs:
# nothing about whether the published binary this job's skip relies
# on has already drifted from HEAD. The only baseline that actually
# answers "is the published fallback binary still trustworthy" is
# the last release tag.
LAST_TAG=$(git tag --sort=-version:refname --list 'v[0-9]*.[0-9]*.[0-9]*' | grep -v dev | head -1)

if [ -z "$LAST_TAG" ] || ! git cat-file -e "$LAST_TAG" 2>/dev/null; then
echo "No usable release tag to diff against — assuming native changed"
# the tag for the version package.json currently declares.
#
# This deliberately does NOT use "the most recent vX.Y.Z tag" —
# a release tag is created by the GitHub Release that kicks off
# publish.yml, but publish itself (and the package.json version
# bump that comes with it) can still fail afterwards, e.g. the
# pre-publish benchmark gate. That leaves a tag on origin with no
# matching publish, which made this job wrongly report "unchanged"
# against a fallback binary that was actually several releases
# stale (#2127).
CURRENT_VERSION=$(node -p "require('./package.json').version")
LAST_TAG="v$CURRENT_VERSION"

if [ -z "$CURRENT_VERSION" ] || ! git cat-file -e "$LAST_TAG" 2>/dev/null; then
echo "No usable release tag ($LAST_TAG) to diff against — assuming native changed"
echo "native_changed=true" >> "$GITHUB_OUTPUT"
exit 0
fi
Expand Down
Loading