Skip to content

chore: narrow over-broad mypy and ty error suppressions #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogenstad merged 1 commit into from
Aug 21, 2026
+4 −6
Merged

chore: narrow over-broad mypy and ty error suppressions #1264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ invalid-assignment = "ignore" # 1 violation in importer/json.py
include = ["infrahub_sdk/node/node.py"]

[tool.ty.overrides.rules]
invalid-argument-type = "ignore" # 9 violations - lines 776, 855, 859, 862
invalid-argument-type = "ignore" # 8 violations


[[tool.ty.overrides]]
Expand All @@ -183,7 +183,6 @@ unused-ignore-comment = "ignore" # Clashes with mypy's type ignore comments
include = ["tests/fixtures/**"]

[tool.ty.overrides.rules]
invalid-argument-type = "ignore" # Test fixtures - dynamic mock data
possibly-missing-attribute = "ignore" # Test fixtures use dynamic attributes

# Test-specific overrides - tests have more lenient type checking
Expand Down Expand Up @@ -231,9 +230,8 @@ include = [
]

[tool.ty.overrides.rules]
invalid-argument-type = "ignore" # 29 violations
invalid-argument-type = "ignore" # 25 violations
invalid-assignment = "ignore"
no-matching-overload = "ignore"
possibly-missing-attribute = "ignore"

[[tool.ty.overrides]]
Expand Down Expand Up @@ -276,7 +274,7 @@ disable_error_code = ["call-overload"]

[[tool.mypy.overrides]]
module = "infrahub_sdk.utils"
disable_error_code = ["arg-type", "attr-defined", "return-value", "union-attr"]
disable_error_code = ["attr-defined", "return-value", "union-attr"]

[[tool.mypy.overrides]]
# ``main.py`` intentionally narrows the ``attributes``/``relationships``/``choices`` fields inherited
Expand All @@ -290,7 +288,7 @@ disable_error_code = ["assignment"]
# The generated read models expose ``kind`` via ``@computed_field`` stacked on ``@property``. mypy
# does not support decorators on top of ``@property`` and flags it, but pydantic requires this order.
module = "infrahub_sdk.schema.generated.read"
disable_error_code = ["misc"]
disable_error_code = ["prop-decorator"]

@ogenstad ogenstad Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here "misc" is a broader version of "prop-decorator", so we're replacing a broad rule with something that's more narrow.


[tool.ruff]
line-length = 120
Expand Down