Merge stable into develop - #1262
Open
infrahub-github-bot-app[bot] wants to merge 3 commits into
Open
Conversation
…mes from (#1253) The command's help said only that it runs a query through InfrahubGraphQLQueryReport, which names an internal type and tells a user nothing about what the answer means. Describe the consequence first: artifact and generator definitions use the verdict to decide how much to regenerate when data changes. State the rule that produces it, note that NAME comes from the queries section of .infrahub.yml, and record on --branch that the answer is branch-dependent because uniqueness constraints live in the schema.
github-actions
Bot
added
the
type/documentation
Deploying infrahub-sdk-python with
|
| Latest commit: |
a83d239
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f11a5664.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests.
@@ Coverage Diff @@
## develop #1262 +/- ##
===========================================
- Coverage 84.16% 78.06% -6.10%
===========================================
Files 147 147
Lines 13045 13045
Branches 1930 1930
===========================================
- Hits 10979 10184 -795
- Misses 1503 2310 +807
+ Partials 563 551 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 34 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The generated read models were suppressing all of mypy's `misc` code to silence one decorated-property error. mypy split that diagnostic into its own `prop-decorator` code in 1.11, the version pinned here, so scope the override to it. Verified by removing each suppression and re-running the checker, which also surfaced three dead entries (mypy `arg-type` on utils, ty `invalid-argument-type` on test fixtures, ty `no-matching-overload`) and two stale violation counts.
…ressions chore: narrow over-broad mypy and ty error suppressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging stable into develop after merging pull request #1253.
Summary by cubic
Clarifies
infrahubctl graphql query-reporthelp and docs, and narrowsmypy/tysuppressions to avoid over-broad ignores. No runtime behavior changes.namerefers to the query underqueriesin.infrahub.yml;--branchnotes schema-dependent uniqueness; docs explain the unique-node rule and its impact on artifact/generator regeneration.mypymiscsuppression withprop-decorator; remove unused suppressions (mypyarg-typeon utils,tyinvalid-argument-typeon test fixtures,tyno-matching-overload); update stale violation counts intyoverrides.Written for commit a83d239. Summary will update on new commits.