Merge stable into develop#1060
Open
infrahub-github-bot-app[bot] wants to merge 5 commits into
Open
Conversation
…ubdirectory `marketplace get --collection` previously fetched a ZIP and dumped every schema flat into the output directory with the version baked into each filename (e.g. `infrahub-dcim-1.0.0.yml`). Re-downloading accumulated stale versions side by side, and the naming was inconsistent with single-schema downloads (`dcim.yml`). Collections are now resolved via the collection metadata endpoint, which lists each member schema and its latest published version. Each member is downloaded individually through the existing `_download_schema` path, so naming, versioning, and error handling match single-schema downloads. Members land in `<output_dir>/<collection name>/<schema name>.yml`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…e collisions Address review findings on the per-schema collection download: - The summary now counts schemas actually downloaded instead of every member entry, so skipped members (missing namespace/name) no longer inflate the count; skipped members also emit a warning instead of disappearing silently. - Members sharing a schema name across namespaces are disambiguated into <collection>/<namespace>/<name>.yml instead of silently overwriting each other. - The stdout `---` separator is tied to emitted documents rather than the raw member index. - Collection metadata items with unexpected shapes are filtered out instead of raising AttributeError. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(ctl): download marketplace collections per-schema into a named subdirectory
Deploying infrahub-sdk-python with
|
| Latest commit: |
3c6b5c0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41e50af8.infrahub-sdk-python.pages.dev |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## develop #1060 +/- ##
===========================================
- Coverage 81.71% 81.67% -0.04%
===========================================
Files 135 135
Lines 11625 12185 +560
Branches 1759 1919 +160
===========================================
+ Hits 9499 9952 +453
- Misses 1575 1646 +71
- Partials 551 587 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging stable into develop after merging pull request #1057.
Summary by cubic
Switches
infrahubctl marketplace get --collectionfrom ZIP downloads to per-schema downloads via the collection metadata endpoint. Schemas now save under<output_dir>/<collection>/<schema>.yml, and stdout outputs a valid multi-document YAML stream.New Features
<output_dir>/<collection>/<schema>.yml; if names clash across namespaces, use<collection>/<namespace>/<schema>.yml. Filenames drop versions and overwrite cleanly.---between schemas when needed; the summary counts only successful downloads and warns on malformed or missing members.Bug Fixes
infrahubctlno longer prints a spuriousError: 1or traceback when exiting withtyper.Exit; it now exits cleanly with only the intended error output.Written for commit 3c6b5c0. Summary will update on new commits.