Conversation
Gate POST /api/admin/volunteer/<id>/select on volunteer.admin (was an unverified "all" #TODO), require a real bool `selected`, clear the in-process get_volunteer_by_event cache after a toggle (the admin list served a stale isSelected before), and Slack-audit the change. The volunteer admin frontend now writes the event-roster bit only through this route; application status goes through the hackathon PATCH. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
update_hackathon_volunteers now runs validate_volunteer_admin_patch: drops isSelected (written only by the select route) and the UI routing key `type` with a warning, folds status onto ALLOWED_VOLUNTEER_STATUSES (blank -> pending), and returns a Message on an unknown status. Deploy after the select-route hardening and after the volunteer admin frontend. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…oute-hardening Harden admin volunteer selection route (single writer for isSelected)
…rdening Strip isSelected from generic volunteer PATCH; validate status (ship last)
…d every call propelauth's require_org_member_with_permission does not inject the user/org into the view; it sets the auth_user proxy and calls the view with Flask's URL params only. Seven admin routes (select, both deposit refunds, the four admin/<type>/<event_id> lists) were declared `def view(user, org, <param>)` and raised TypeError (missing 'user' and 'org') on every request. The select route surfaced it in Sentry once PR #280 made its auth gate actually pass. - Read identity via auth_user.user_id; view params now match URL params. - The four list routes also gain volunteer.admin + req_to_org_id=getOrgId (they were "all" with the default org resolver => always 403). - Route-level regression tests via Flask test_client with common.auth stubbed; one asserts every view signature == its rule arguments so the class of bug can't recur. Verified they fail with the exact Sentry TypeError on develop. - CLAUDE.md gotcha. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Fix admin volunteer routes: phantom (user, org) params 500'd every call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.