Skip to content

📖 Document ClusterObjectDeployment rollout concepts - #3152

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:docs/cod-concepts
Nov 11, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:docs/cod-concepts

Conversation

@perdasilva

@perdasilva perdasilva commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Dependency and merge order

Merge after #3147. This branch is based directly on main (40e1251f), not stacked on the implementation branch. It documents the spec-level progressDeadlineMinutes API introduced by #3147, so merging it first would describe an API that is not yet on main.

Summary

  • Add docs/draft/concepts/clusterobjectdeployment.md covering COD responsibilities, revision identity and ownership, status conditions, rollout deadlines and recovery, history retention, and ClusterExtension integration.
  • Keep COS concepts focused on resource readiness and completion, and link deployment-level policy to the new COD page.
  • Keep the standalone tutorial focused on the walkthrough, linking detailed semantics to the concept page; correct stale object/ref field names and ClusterExtension integration text.
  • Update the historical COD design notice to point to current deadline semantics.

These four hand-authored documentation changes were split out of #3147. Generated API references, API/controller changes, tests, and the corrected standalone sample remain in #3147. No runtime code, API definitions, or generated artifacts change in this PR.

Verification

MkDocs rendering and live E2E scenarios were not run. MkDocs is not installed locally.

Summary by CodeRabbit

  • Documentation
    • Added an overview of the experimental, cluster-scoped ClusterObjectDeployment (COD) API, covering revisions, status, rollout deadlines, history, deletion, and ClusterExtension integration.
    • Clarified that rollout time is budgeted from the current ClusterObjectSet’s creation, and that changing the deadline recalculates the budget—even after timeout. ClusterObjectSet no longer exposes a deadline field.
    • Updated the management tutorial with revised commands, deadline guidance, and links to concept and status-condition documentation.

Add a dedicated COD concept page covering desired content, revision
management and ownership, status, rollout deadlines, and history retention.
Keep COS concepts focused on resource readiness and completion, link the
standalone tutorial to COD semantics, and correct stale tutorial fields
and ClusterExtension integration guidance.

This documentation describes the spec-level deadline API introduced by
operator-framework#3147 and must merge after that PR.
The branch is based directly on main, not stacked on the API change.

Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
@netlify

netlify Bot commented Nov 11, 2026

Copy link
Copy Markdown

👷 Deploy request for olmv1 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 922c9d9

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2026
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changes add a COD concept document and update related design, COS concept, and tutorial documentation. They describe COD revisions, rollout conditions and deadlines, history handling, and ClusterExtension integration.

Changes: ClusterObjectDeployment documentation

Layer / File(s) Summary
COD contract and revisions
docs/draft/concepts/clusterobjectdeployment.md, docs/draft/tutorials/manage-clusterobjectdeployments.md
The concept describes COD fields, revision numbering, and which template edits create revisions. The tutorial links to those rules.
Rollout status and lifecycle
docs/draft/concepts/clusterobjectdeployment.md, docs/designs/object-controller/clusterobjectdeployment.md, docs/draft/concepts/clusterobjectsets.md, docs/draft/tutorials/manage-clusterobjectdeployments.md
The documents describe ownership checks, status conditions, deadline behavior, and history pruning. The design notice marks its deadline semantics as historical, and the tutorial explains how to change the rollout budget.
Integration and tutorial workflow
docs/draft/concepts/clusterobjectdeployment.md, docs/draft/concepts/clusterobjectsets.md, docs/draft/tutorials/manage-clusterobjectdeployments.md
The concept describes ClusterExtension integration. The tutorial updates the manifest patch example, referenced-content guidance, and standalone workflow description. The COS concept adds links to COD documentation.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Possibly related PRs

Suggested reviewers: grokspawn, fao89, dtfranz

Merge Risk: Minimal · up to 922c9

This PR adds and updates documentation for ClusterObjectDeployment rollout behavior and has no runtime effect. It documents the API from #3147, so it should merge after that PR. No actionable risk remains.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the main documentation change and uses the required documentation icon.
Description check Passed The description provides the change summary, motivation, merge dependency, scope, and verification results. It does not reproduce the reviewer checklist or provide an explicit issue link, but the requ…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description provides the change summary, motivation, merge dependency, scope, and verification results. It does not reproduce the reviewer checklist or provide an explicit issue link, but the required context is mostly complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: e9a758fb-3deb-40d8-ae3e-80499c78f714
Commits

Reviewing files that changed from the base of the PR and between 40e1251 and 922c9d9.

Files selected for processing: 4

  • docs/designs/object-controller/clusterobjectdeployment.md
  • docs/draft/concepts/clusterobjectdeployment.md
  • docs/draft/concepts/clusterobjectsets.md
  • docs/draft/tutorials/manage-clusterobjectdeployments.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@perdasilva perdasilva removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2026
@perdasilva
perdasilva marked this pull request as ready for review November 11, 2026 15:01
@openshift-ci
openshift-ci Bot requested review from fao89 and fgiudici November 11, 2026 15:02
@tmshort

tmshort commented Nov 11, 2026

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2026
@fao89

fao89 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 6262f32 into operator-framework:main Nov 11, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants