Repository navigation
Conversation
Prepare the PR3 package boundary with reusable world, resource, condition, and command helpers. Keep step registration intact and observe demo commands through an optional interface so shared steps do not depend on the demo recorder. Refs: OPRUN-4784 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Extract port-forward and metrics helpers before moving catalogd steps. Make recording hooks explicit in platform and legacy suites, and document the incremental ownership boundary. Keep cross-component object lookups shared so component branches can build and land independently. Refs: OPRUN-4784 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Move HA, proxy, and TLS assertions with catalog-specific state and restoration hooks. Consume shared preparation without depending on platform, operator-controller, or object-controller step extractions. Refs: OPRUN-4784 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
👷 Deploy request for olmv1 pending review.Visit the deploys page to approve it
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move HA, proxy, and TLS step definitions into
test/internal/e2e/catalogd/steps, together with catalogd-specific proxy state and deployment-restoration hooks. Register them in the catalogd and legacy entry points and remove their registrations from shared steps. Consume shared preparation without requiring another component extraction.Parallel — merge wave 3. Depends on #3139, which follows #3138. After both preparation PRs merge, this extraction can be reviewed and merged in any order with the catalogd, platform, operator, and object sibling extractions. This draft currently targets
mainand includes the shared preparation; rebase only its own commit onto refreshedmainafter preparation lands. Shared suite registrations can still require ordinary merge-conflict resolution.The focused change is e3e5184d: 8 changed files relative to
ce52d8edd61bf2849ac2fef60e3abd55cb1f4e22. Feature contents and tag policy are preserved.Jira: https://redhat.atlassian.net/browse/OPRUN-4784
Design:
docs/designs/e2e-per-component.mdValidation
Local validation uses Go 1.26.5 and
GOFLAGS=-buildvcs=false:main.make verify,make lint(zero issues), andumask 022; make test-unit(55 passing packages, race detection and coverage).Reviewer Checklist