Bug Report
What did you do?
Built an operator as a single shaded jar depending on both io.javaoperatorsdk:operator-framework-core (5.6.1) and io.javaoperatorsdk:kubernetes-webhooks-framework-core (3.0.4). Both artifacts generate a root-level version.properties via the git-commit-id-maven-plugin, so the two files collide at the same jar entry path.
What did you expect to see?
The operator startup log reports operator-framework-core's commit id and build time, which Utils.loadFromProperties() reads from version.properties.
What did you see instead? Under which circumstances?
ClassLoader.getResourceAsStream returns the first match, so Utils can silently report the webhooks framework's commit id and build time as the SDK version. This only surfaces when the jars are merged into one (or the classpath puts the webhooks jar first), which is probably why it went unnoticed: setups that keep the jars separate, such as Quarkus, usually resolve the operator-framework-core copy first.
Possible Solution
Give each artifact a uniquely named properties file:
- operator-framework-core:
operator-sdk-version.properties, updating the lookup in Utils.loadFromProperties() (its only reader)
- kubernetes-webhooks-framework-core: for example
kubernetes-webhooks-framework-version.properties (nothing reads it today, so it is only a rename); I can file a companion issue there
Happy to contribute PRs (for both repos if needed).
Bug Report
What did you do?
Built an operator as a single shaded jar depending on both
io.javaoperatorsdk:operator-framework-core(5.6.1) andio.javaoperatorsdk:kubernetes-webhooks-framework-core(3.0.4). Both artifacts generate a root-levelversion.propertiesvia the git-commit-id-maven-plugin, so the two files collide at the same jar entry path.What did you expect to see?
The operator startup log reports operator-framework-core's commit id and build time, which
Utils.loadFromProperties()reads fromversion.properties.What did you see instead? Under which circumstances?
ClassLoader.getResourceAsStreamreturns the first match, soUtilscan silently report the webhooks framework's commit id and build time as the SDK version. This only surfaces when the jars are merged into one (or the classpath puts the webhooks jar first), which is probably why it went unnoticed: setups that keep the jars separate, such as Quarkus, usually resolve the operator-framework-core copy first.Possible Solution
Give each artifact a uniquely named properties file:
operator-sdk-version.properties, updating the lookup inUtils.loadFromProperties()(its only reader)kubernetes-webhooks-framework-version.properties(nothing reads it today, so it is only a rename); I can file a companion issue thereHappy to contribute PRs (for both repos if needed).