Automatically add _ftindex:<yes/no> tag at creator start based on indexing configuration

[benoit74]

Fix #295

Remark: IMHO this needs to be merged in a major release because it changes the behavior of Creator.add_metadata method (it is not possible to set "Tags" metadata once scraper has started). Am I too finicky?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e0f7b72) to head (cef6a81).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #305   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         2545      2555   +10     
  Branches       363       365    +2     
=========================================
+ Hits          2545      2555   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rgaudin]

LGTM

[rgaudin]

Remark: IMHO this needs to be merged in a major release because it changes the behavior of Creator.add_metadata method (it is not possible to set "Tags" metadata once scraper has started). Am I too finicky?

Well it could be argued that the API hasn't changed and it's just fixing the behavior… but it lasted so long that it is now seen as a change.

I have no opinion

[benoit74]

Let's merge as-is, we can always refine in the aftermath if needed.

This is indeed not an API change, and not a "usual" behavior (at least not recommended anymore since 5.0). So I propose to keep this in this release, I will just amend the CHANGELOG to emphasis this is a behavior change rather than a breaking one.