Repository navigation
fix(loader): platform inheritance (ref/inherits) and a version's min_client (0.0.64) - #49
Merged
Merged
Conversation
…nherits, and the loader fills it in (0.0.64)
`xpm.inherits` was parsed and never used, and a platform written in the V1
form `macosx = { ref = "linux" }` became a version named "ref" whose url
was "linux" (xlings: `xim:luban-fonts@ref ... Only HTTPS is supported` on
macOS and Windows). Both spellings now record inheritance; after parsing,
each inheriting platform receives the versions it lacks and, when it has
none of its own, the deps, exports and source of the platform it inherits,
along the chain, stopping at a cycle or an unknown platform.
Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
… (min_client)
`["2026.10.16.1"] = { min_client = "2026.10.16.1" }` is parsed into
PlatformResource::min_client, so a client resolving a package with no
version named can pass over the versions it cannot use, before fetching
anything (xlings: a Luban edition newer than the client).
Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
Sunrisepeak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xpm.inheritswas parsed and never used. A platform written in the V1 formmacosx = { ref = "linux" }became a version namedrefwhose url was"linux"; xlings then installedxim:luban-fonts@refon macOS and Windows and failed withdownload failed: Only HTTPS is supported.inherits = "<platform>",{ ref = "<platform>" }) now record inheritance. After parsing,resolve_inheritancegives each inheriting platform the versions it lacks and, when it declares none, thedeps,runtime_deps,build_deps,exportsandsourceof the platform it inherits. The chain is followed and stops at a cycle or an unknown platform. A platform-levelrefis no longer read as a version.min_client = "2026.10.16.1"→PlatformResource::min_client. A client resolving a package with no version named passes over the versions it cannot use before fetching anything (xlings: a Luban edition newer than the client).docs/architecture.mddescribes both.Test
mcpp test:LoaderTest.PlatformReferenceIsInheritanceNotAVersion,LoaderTest.InheritingPlatformKeepsItsOwnVersionsAndFollowsChains(V1 reference,inheritswith own versions, a chain, a cycle),LoaderTest.AVersionNamesTheOldestClientThatCanUseIt; all suites pass.Consumed by xlings 2026.10.16.2. The index no longer relies on the alias form (xim-pkgindex#987).
Co-authored-by: speak-agent 248744407+speak-agent@users.noreply.github.com