Repository navigation
system.admin_step: a recipe declares a step only an administrator may take (0.0.63) - #48
Merged
Merged
Conversation
… may take, never runs it -- the host asks once, through its one door, or records it when nobody can answer (0.0.63)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
system.admin_step: a recipe declares a step only an administrator may take (0.0.63)
system.admin_step(argv, why)records a deferred request (op = "admin";target= why plus each word, joined by 0x1F) and never runs it.Why: a recipe that ran
sudoinside an unattended install (xlingsself doctor --fixrepairing another SubOS, the Luban OS window) waited on a terminal nobody could read. With this, the host decides who is asked and when: xlings asks once after the install through its single elevation path, or keeps the step forself doctor --fix.Compatibility: it reuses the existing request channel, so neither the C++ API nor the worker protocol changes. Older libxpkg has no such function; recipes check for it first (documented in
docs/architecture.md).Tests:
ExecutorTest.AnAdminStepIsDeclaredNotRun.