Repository navigation
feat(openworkflow): configurable worker lease duration - #878
Merged
jamescmartinez merged 2 commits intoOct 12, 2026
Merged
Conversation
Add a `leaseDurationMs` worker option, also accepted by `OpenWorkflow#newWorker` and the CLI `worker` config. It replaces the fixed 30s lease used when claiming and extending workflow runs. Heartbeats stay at half the lease, and missing or invalid values fall back to the 30s default.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Node runs timer delays above 2^31-1 ms after 1 ms, so a very long lease would heartbeat continuously. Cap the interval, and check the heartbeat timing with controlled timers.
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #877
Summary
Adds a
leaseDurationMsworker option so deployments with very long steps or slow storage can tune the 30s lease. Heartbeats stay at half the lease, so there is a single knob and no way to configure a heartbeat that outlives the lease.Changes
WorkerOptions.leaseDurationMs(default 30000), used when claiming and extending runs; missing/invalid values fall back to the defaultOpenWorkflow#newWorker()and the CLIworkerconfig accept it