Skip to content

[test_operator] Remove unused HorizonTest parameters - #4085

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:remove-unused-horizontest-parameters
Aug 5, 2026
Merged

[test_operator] Remove unused HorizonTest parameters#4085
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:remove-unused-horizontest-parameters

Conversation

@kstrenkova

@kstrenkova kstrenkova commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

These parameters will be shortly removed from test-operator as well due to their redundancy. Every parameter is present in test-operator as configurable, but in reality, the values are hard-coded in the horizontest TCIB script. Therefore, all these parameters have not been used (nobody reported the bug) and they should not have been configurable from the start, as discussed with Horizon team.

This PR is related to a test-operator change [1] and follows up a previous cleanup [2].

[1] openstack-k8s-operators/test-operator#474
[2] http://github.com/openstack-k8s-operators/ci-framework/pull/4071

These parameters will be shortly removed from test-operator
as well due to their redundancy. Every parameter is present in
test-operator as configurable, but in reality, the values are
hard-coded in the horizontest TCIB script. Therefore, all these
parameters have not been used (nobody reported the bug) and they
should not have been configurable from the start, as discussed
with Horizon team.

Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>

@michburk michburk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evallesp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Aug 5, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 1680b73 into openstack-k8s-operators:main Aug 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants