handshake, writeread: load the cert and key once, not per iteration - #98
Closed
quarckster wants to merge 1 commit into
Closed
quarckster wants to merge 1 commit into
quarckster wants to merge 1 commit into
Conversation
Reopening servercert.pem and serverkey.pem for every handshake measured NTFS FCB contention rather than OpenSSL. All handshake -s/-p/-P levels step down, so this needs a rebaseline. Assisted-by: Claude:claude-opus-5
quarckster
force-pushed
the
handshake-preload-cert-key
branch
from
September 17, 2026 14:58
3961869 to
70e1cd0
Compare
quarckster
marked this pull request as ready for review
September 21, 2026 18:48
nhorman
approved these changes
Sep 22, 2026
github-project-automation
Bot
moved this from Waiting Review
to Waiting Merge
in Development Board
t8m
approved these changes
Sep 23, 2026
Member
|
So this will change the perf numbers quite severely on all branches. Will you re-run the test for the unsupported branches so the baseline numbers for for example 1.1.1 is also updated? |
t8m
added
the
approval: done
Member
Author
|
Yes, I change the baselines for such cases |
t8m
pushed a commit
that referenced
this pull request
Sep 23, 2026
Reopening servercert.pem and serverkey.pem for every handshake measured NTFS FCB contention rather than OpenSSL. All handshake -s/-p/-P levels step down, so this needs a rebaseline. Assisted-by: Claude:claude-opus-5 Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Merge-date: Wed Sep 23 09:27:53 2026 Merged-from: #98
Member
|
Merged. Thank you. |
github-project-automation
Bot
moved this from Waiting Merge
to Done
in Development Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening servercert.pem and serverkey.pem for every handshake measured NTFS FCB contention rather than OpenSSL. All handshake -s/-p/-P levels step down, so this needs a rebaseline.