Fix audit-exporter SCC denial by setting its serviceAccountName - #465
Fix audit-exporter SCC denial by setting its serviceAccountName#465dwelch0 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe audit-exporter DaemonSet now runs with the ChangesAudit exporter deployment
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dwelch0 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 72.44% 72.44%
=======================================
Files 11 11
Lines 704 704
=======================================
Hits 510 510
Misses 173 173
Partials 21 21 🚀 New features to boost your workflow:
|
|
/retest-required |
|
@dwelch0: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Set
serviceAccountName: splunk-forwarder-operatoron theaudit-exporterDaemonSet in the OLM artifacts template.Follow up to #457
Why
#457 migrated
splunkforwarderSCC grant from thedefaultserviceaccount to a dedicated serviceaccount:splunk-forwarder-operator. This broken deployment of the audit-exporter component. Theaudit-exporterdaemonset does not specify aserviceAccountName, and therefore defaults to using thedefaultservice account. Because audit-exporter requiresprivlieged: trueandrunAsUser: 0, it too requires the SCC grants that have been moved tosplunk-forwarder-operatorSummary by CodeRabbit