Skip to content

Fix audit-exporter SCC denial by setting its serviceAccountName - #465

Open
dwelch0 wants to merge 1 commit into
openshift:masterfrom
dwelch0:fix-audit-exporter-permissions
Open

Fix audit-exporter SCC denial by setting its serviceAccountName#465
dwelch0 wants to merge 1 commit into
openshift:masterfrom
dwelch0:fix-audit-exporter-permissions

Conversation

@dwelch0

@dwelch0 dwelch0 commented Aug 3, 2026

Copy link
Copy Markdown

Summary

Set serviceAccountName: splunk-forwarder-operator on the audit-exporter DaemonSet in the OLM artifacts template.

Follow up to #457

Why

#457 migrated splunkforwarder SCC grant from the default serviceaccount to a dedicated serviceaccount: splunk-forwarder-operator. This broken deployment of the audit-exporter component. The audit-exporter daemonset does not specify a serviceAccountName, and therefore defaults to using the default service account. Because audit-exporter requires privlieged: true and runAsUser: 0, it too requires the SCC grants that have been moved to splunk-forwarder-operator

Summary by CodeRabbit

  • Bug Fixes
    • Updated the audit exporter to run with the appropriate service account, improving deployment permissions and reliability.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 7a585d6a-d230-4c4d-ac62-d967bae12bfa

📥 Commits

Reviewing files that changed from the base of the PR and between b0a8e9b and 168f8d3.

📒 Files selected for processing (1)
  • hack/olm-registry/olm-artifacts-template.yaml

Walkthrough

The audit-exporter DaemonSet now runs with the splunk-forwarder-operator service account.

Changes

Audit exporter deployment

Layer / File(s) Summary
Service account wiring
hack/olm-registry/olm-artifacts-template.yaml
The audit-exporter DaemonSet pod template specifies the splunk-forwarder-operator service account.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: dustman9000


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Container-Privileges ❌ Error The audit-exporter container has securityContext.privileged: true; the parsed DaemonSet also runs with runAsUser: 0. The check flags privileged containers. Remove privileged execution and root use where possible. If required, document and approve a narrowly scoped security exception.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the service account change that resolves the audit-exporter SCC denial.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes only the YAML DaemonSet and adds no test titles. Existing Ginkgo titles are static and contain no dynamic values.
Test Structure And Quality ✅ Passed The PR changes only one YAML manifest line and adds no Ginkgo tests or It blocks, so the listed test-quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed The patch changes only one YAML template line and adds no Ginkgo e2e tests, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only a YAML template and adds no Ginkgo e2e tests, so SNO test compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The commit adds only serviceAccountName to the audit-exporter DaemonSet; it adds no topology-dependent scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The PR changes only YAML by adding serviceAccountName; it adds no OTE process-level code or stdout writes. The existing e2e runner has no direct stdout output.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The patch changes only one YAML template line and adds no Ginkgo e2e test or network connectivity code.
No-Weak-Crypto ✅ Passed The only change adds a Kubernetes serviceAccountName; the PR diff contains no weak algorithms, custom crypto, or secret/token comparisons.
No-Sensitive-Data-In-Logs ✅ Passed The patch adds only a Kubernetes service account field; it adds no logging code, log fields, credentials, tokens, PII, hostnames, or customer data.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Mhodesty and nephomaniac August 3, 2026 20:14
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dwelch0
Once this PR has been reviewed and has the lgtm label, please assign bmeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.44%. Comparing base (b0a8e9b) to head (168f8d3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          11       11           
  Lines         704      704           
=======================================
  Hits          510      510           
  Misses        173      173           
  Partials       21       21           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mhodesty

Mhodesty commented Aug 3, 2026

Copy link
Copy Markdown

/retest-required

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@dwelch0: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 168f8d3 link true /test validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants