Skip to content

config: add stolostron/capi-tests CAPZ e2e jobs#3377

Open
RadekCap wants to merge 3 commits into
openshift:mainfrom
RadekCap:add-capz-qe-jobs
Open

config: add stolostron/capi-tests CAPZ e2e jobs#3377
RadekCap wants to merge 3 commits into
openshift:mainfrom
RadekCap:add-capz-qe-jobs

Conversation

@RadekCap

@RadekCap RadekCap commented Mar 27, 2026

Copy link
Copy Markdown

Summary

  • Add capz-qe section to openshift-customizations.yaml to register stolostron/capi-tests CAPZ e2e jobs in Sippy
  • Registers the periodic job (periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e and pull-ci-stolostron-capi-tests-configure-prow-mgmt-capz-e2e) by exact name

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Enabled a CAPZ end-to-end periodic CI job: periodic E2E validation for CAPZ components is now active to improve QA coverage and catch regressions earlier.

Register the CAPZ QE periodic and presubmit jobs in Sippy so they
appear in the dashboard.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci-robot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d8b3664d-abc7-4e72-94c9-647329bf7433

📥 Commits

Reviewing files that changed from the base of the PR and between 5670282 and 9903d05.

📒 Files selected for processing (1)
  • config/openshift-customizations.yaml

Walkthrough

Adds a new top-level releases.capi-qe section to config/openshift-customizations.yaml and enables one CAPZ periodic job by setting releases.capi-qe.jobs.periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e: true.

Changes

Release Configuration

Layer / File(s) Summary
Add releases.capi-qe job flag
config/openshift-customizations.yaml
Adds releases.capi-qe release entry and sets releases.capi-qe.jobs.periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e: true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 20
✅ Passed checks (20 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding CAPZ e2e jobs from stolostron/capi-tests to the configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed PR #3377 changes only config/openshift-customizations.yaml (YAML); no Go code to evaluate, so Go error-handling patterns are not applicable.
Sql Injection Prevention ✅ Passed PR changes only config/openshift-customizations.yaml by adding YAML job enablement flags; no SQL statements or query construction is introduced.
Excessive Css In React Should Use Styles ✅ Passed PR #3377 changes only config/openshift-customizations.yaml (adds CAPZ job flags); no React/JSX code or inline CSS introduced, so the “useStyles for inline CSS” check is not applicable.
Test Coverage For New Features ✅ Passed PR #3377 changes only config/openshift-customizations.yaml (adds releases.capi-qe job enablement flags); no Go/logic changes, so test-coverage requirement is waived for config-only changes.
Single Responsibility And Clear Naming ✅ Passed PR only changes config/openshift-customizations.yaml (rename capz-qe→capi-qe and removes one job entry); no packages/structs/methods are added or renamed.
Stable And Deterministic Test Names ✅ Passed PR #3377 modifies only config/openshift-customizations.yaml (adds releases.capi-qe job enablement); no Ginkgo test files/titles were changed, so no nondeterministic test names were introduced.
Test Structure And Quality ✅ Passed No Ginkgo test code found in repo (.go files: 0 hits for onsi/ginkgo and 0 for Describe/BeforeEach/AfterEach/Eventually/Consistently). PR only updates config/openshift-customizations.yaml (capi-qe...
Microshift Test Compatibility ✅ Passed PR #3377 only updates config/openshift-customizations.yaml job enablement (no Ginkgo e2e test code changed), so there are no new MicroShift-incompatible APIs to flag.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates config/openshift-customizations.yaml (adds capi-qe jobs). Repo search shows no new Ginkgo e2e test code in this change to assess for SNO assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed PR changes only config/openshift-customizations.yaml by adding enabling keys for CAPZ e2e Prow jobs; no manifests/operator/controller code or scheduling constraints (affinity/topology/replicas) wer...
Ote Binary Stdout Contract ✅ Passed PR only updates config/openshift-customizations.yaml (adds capi-qe job enablement). Repo scan found no fmt/klog stdout writes in Go main/init/TestMain/Ginkgo suite setup (only scripts/updatesuites....
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR #3377 only updates config/openshift-customizations.yaml (adds capi-qe.jobs.periodic-ci-...: true); no new Ginkgo e2e test code or external/internet logic to analyze.
No-Weak-Crypto ✅ Passed config/openshift-customizations.yaml PR change only adds capi-qe job enablement; regex scan of that file found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB/constant-time/token/secret compare patterns.
Container-Privileges ✅ Passed PR only updates config/openshift-customizations.yaml (+3/-0) enabling a CAPZ e2e periodic job; no container/K8s privilege fields (privileged/hostPID/hostNetwork/allowPrivilegeEscalation) added or m...
No-Sensitive-Data-In-Logs ✅ Passed Diff only adds capi-qe job enablement in config/openshift-customizations.yaml; no logging changes or sensitive tokens/passwords/PII detected in the added lines.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch add-capz-qe-jobs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from deepsm007 and sosiouxme March 27, 2026 09:31
@openshift-ci-robot

Copy link
Copy Markdown

Scheduling required tests:
/test e2e

@marek-veber marek-veber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026
@RadekCap

Copy link
Copy Markdown
Author

/assign dgoodwin

@RadekCap

Copy link
Copy Markdown
Author

/retest

Replace the overly broad regexp with an exact job entry for
pull-ci-stolostron-capi-tests-configure-prow-mgmt-capz-e2e.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026
@openshift-ci

openshift-ci Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci

openshift-ci Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marek-veber, RadekCap
Once this PR has been reviewed and has the lgtm label, please ask for approval from dgoodwin. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown

Scheduling required tests:
/test e2e

@RadekCap

Copy link
Copy Markdown
Author

Can anybody please do review here? Thank you. This is currently blocking our next work.

I wouldn't ping you all but I don't know where to ask properly and I don't want to ping you personally on Slack or elsewhere.

@deads2k
@deepsm007
@dgoodwin
@neisw
@petr-muller
@stbenjam
@xueqzhan
@sosiouxme
@smg247

Comment thread config/openshift-customizations.yaml Outdated
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 9, 2026
Rename the section from capz-qe to capi-qe and remove the
pull-ci-stolostron-capi-tests-configure-prow-mgmt-capz-e2e job entry,
keeping only the periodic job.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@RadekCap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build 9903d05 link true /test build
ci/prow/agentic-images 9903d05 link true /test agentic-images
ci/prow/unit 9903d05 link true /test unit
ci/prow/yaml-lint 9903d05 link true /test yaml-lint
ci/prow/security 9903d05 link true /test security
ci/prow/images 9903d05 link true /test images
ci/prow/lint 9903d05 link true /test lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants