OPNET-601: Add on-prem haproxy timeline to e2e interval chart#31290
OPNET-601: Add on-prem haproxy timeline to e2e interval chart#31290mkowalski wants to merge 1 commit into
Conversation
The on-prem haproxy monitor test constructs intervals with source OnPremHaproxyMonitor when haproxy detects a kube-apiserver as down, but the spyglass interval chart template had no handler for that source, so the intervals were never rendered. Add a precondition function, a value function and an onprem-haproxy timeline group placed next to the disruption and apiserver-shutdown groups, so that haproxy events can be correlated with apiserver disruption events. Follows the pattern of 08cb5eb. Regenerated bindata with 'make update-bindata'.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@mkowalski: This pull request references OPNET-601 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting WalkthroughThis PR adds detection and formatting for "OnPremHaproxyMonitor" events and wires a new "onprem-haproxy" timeline group into chart rendering and test bindata. ChangesOnPremHaproxy Timeline Activity
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
Scheduling required tests: |
|
@coderabbitai you failed the check Container-Privileges but this PR does not add any such manifests. what file and line are you getting that from |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get all review comments and reviews on PR `#31290`
gh pr view 31290 --repo openshift/origin --json reviews,comments
# Also get the review comments specifically
gh api repos/openshift/origin/pulls/31290/reviewsLength of output: 24590
This PR only modifies You can safely ignore or override this check for this PR. I'll note this as a known false-positive pattern to improve future behavior. ✏️ Learnings added
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
@coderabbitai summary |
✅ Action performedSummary regeneration triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
openshift-ci
Bot
added
the
ready-for-human-review
|
@mkowalski: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Implements https://issues.redhat.com/browse/OPNET-601 (mirrored at https://redhat.atlassian.net/browse/OPNET-601).
The on-prem haproxy monitor test added in #29149 constructs intervals with source
OnPremHaproxyMonitorwhen haproxy detects a kube-apiserver as down, but the spyglass interval chart template had no handler for that source, so the intervals were present in the intervals JSON yet never rendered on the timeline.As suggested in #29149 (review), update the interval template so haproxy events can be correlated with apiserver disruption events, following the pattern of 08cb5eb:
isOnPremHaproxyActivity()precondition matchingsource === "OnPremHaproxyMonitor"onPremHaproxyValue()classifying the intervals asDisruption(same coloring as the apiserver disruption rows)onprem-haproxytimeline group placed next to thedisruption,apiserver-shutdownandapi-unreachablegroupsmake update-bindataVerified with
make verify-bindata,go buildof the affected packages, andnode --checkon the template JavaScript.Summary by CodeRabbit