Skip to content

NO-JIRA: Add Jacob and Jubitta as image approvers#31279

Open
jubittajohn wants to merge 1 commit into
openshift:mainfrom
jubittajohn:update-image-owners
Open

NO-JIRA: Add Jacob and Jubitta as image approvers#31279
jubittajohn wants to merge 1 commit into
openshift:mainfrom
jubittajohn:update-image-owners

Conversation

@jubittajohn

@jubittajohn jubittajohn commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated internal code review/ownership configuration to reflect current reviewers and approvers.

Note: This release contains no user-visible changes.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@jubittajohn: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0a9d5b41-aeec-4436-bd74-9ba6d9699478

📥 Commits

Reviewing files that changed from the base of the PR and between dd70e8b and 87ec6d5.

📒 Files selected for processing (1)
  • test/extended/util/image/OWNERS
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/extended/util/image/OWNERS

Walkthrough

Updated test/extended/util/image/OWNERS to add jacobsee and jubittajohn to both the reviewers and approvers lists for the test image utilities directory.

Changes

OWNERS File Membership Update

Layer / File(s) Summary
Add team members as reviewers and approvers
test/extended/util/image/OWNERS
jacobsee and jubittajohn are added to the reviewers list (lines 5–6) and to the approvers list (lines 7–11).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding Jacob and Jubitta as image approvers in the OWNERS file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies test/extended/util/image/OWNERS (a configuration file), not Ginkgo test names. The image.go file in that directory is a utility library with no test definitions. Check is not appli...
Test Structure And Quality ✅ Passed The PR only modifies test/extended/util/image/OWNERS (a code ownership metadata file), not Ginkgo test code. The check for Ginkgo test quality is not applicable to OWNERS file updates.
Microshift Test Compatibility ✅ Passed PR contains no new Ginkgo e2e tests. Only OWNERS file metadata was updated to add new reviewers/approvers; custom check for MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies test/extended/util/image/OWNERS file to update code ownership; no new Ginkgo e2e tests are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies OWNERS governance file (test/extended/util/image/OWNERS), not deployment manifests, operator code, or controllers targeted by the topology-aware scheduling check.
Ote Binary Stdout Contract ✅ Passed The PR only modifies test/extended/util/image/OWNERS, a pure YAML configuration file containing reviewer and approver metadata. It contains no executable code, main functions, logging setup, or any...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies OWNERS file for ownership metadata; no new Ginkgo e2e tests are added, so IPv6/disconnected network compatibility check is not applicable.
No-Weak-Crypto ✅ Passed PR only updates OWNERS file metadata with no cryptographic code changes, making the weak-crypto check not applicable.
Container-Privileges ✅ Passed PR only updates OWNERS metadata file; no container/K8s manifests with privilege settings are introduced or modified.
No-Sensitive-Data-In-Logs ✅ Passed PR only modifies OWNERS file with GitHub usernames for code reviewers/approvers. No passwords, tokens, API keys, PII, session IDs, internal hostnames, or sensitive data in logs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bertinatto and ingvagabund June 10, 2026 18:29
@openshift-ci openshift-ci Bot added the e2e-images-update Related to images used by e2e tests label Jun 10, 2026
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@bertinatto bertinatto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Jacob and Jubitta have permissions to push to our quay.io repository, so it makes sense for them to be approvers in this package.

@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jubittajohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2026
@jubittajohn

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-trt

openshift-trt Bot commented Jun 11, 2026

Copy link
Copy Markdown

Job Failure Risk Analysis for sha: dd70e8b

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High
install should succeed: other
This test has passed 99.41% of 4051 runs on release 5.0 [Overall] in the last week.

Signed-off-by: jubittajohn <jujohn@redhat.com>
@jubittajohn jubittajohn force-pushed the update-image-owners branch from dd70e8b to 87ec6d5 Compare June 11, 2026 11:37
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@jubittajohn

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@jubittajohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips 87ec6d5 link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt

openshift-trt Bot commented Jun 12, 2026

Copy link
Copy Markdown

Job Failure Risk Analysis for sha: 87ec6d5

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-gcp-ovn Low
[Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: services on a user defined primary network should be reachable through their cluster IP, node port and load balancer L2 primary UDN with custom network, cluster-networked pods, NodePort service [Suite:openshift/conformance/parallel]
This test has passed 0.00% of 3 runs on release 5.0 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:gcp Procedure:none SecurityMode:default Topology:ha Upgrade:micro] in the last week.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 Low
[Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: services on a user defined primary network should be reachable through their cluster IP, node port and load balancer L2 primary UDN with custom network, cluster-networked pods, NodePort service [Suite:openshift/conformance/parallel]
This test has passed 0.00% of 1 runs on release 5.0 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv6 OS:rhcos9 Owner:eng Platform:metal Procedure:none SecurityMode:default Topology:ha Upgrade:micro] in the last week.
pull-ci-openshift-origin-main-e2e-vsphere-ovn Low
[Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: services on a user defined primary network should be reachable through their cluster IP, node port and load balancer L2 primary UDN with custom network, cluster-networked pods, NodePort service [Suite:openshift/conformance/parallel]
This test has passed 0.00% of 4 runs on release 5.0 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:vsphere Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi Low
[Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: services on a user defined primary network should be reachable through their cluster IP, node port and load balancer L2 primary UDN with custom network, cluster-networked pods, NodePort service [Suite:openshift/conformance/parallel]
This test has passed 0.00% of 3 runs on release 5.0 [Architecture:amd64 FeatureSet:default Installer:upi JobTier:standard Network:ovn NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:vsphere Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants